Feature/main/tratar classe #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add some marks
ppedroam
reviewed
Feb 18, 2025
| import Foundation | ||
| import UIKit | ||
|
|
||
| class RioAlertHelper { |
Owner
There was a problem hiding this comment.
futuramente vou sugerir para usar composição para essa funcao (aula de LI)
mas por enquanto sugiro apenas usar enum ao inves de classe
já que nao tem necessidade de instanciar esse objeto
ppedroam
reviewed
Feb 18, 2025
| import Foundation | ||
| import UIKit | ||
|
|
||
| class RioResetPasswordViewConfigurator { |
Owner
There was a problem hiding this comment.
nao interessante performar operações da viewController fora dela (com exceção do coordinator)
todas as funcoes desse objeto recebem viewController de parâmetro para performar acoes nela
eu sugiro duas opções:
- deixar tudo na viewController mesmo
- tirar View da ViewController e fazer ajustes de layout na View (igual mostrado ontem na aula)
ppedroam
reviewed
Feb 18, 2025
| recoverPasswordButton.setTitleColor(.white, for: .normal) | ||
| recoverPasswordButton.isEnabled = isValid | ||
| private func updateRecoverPasswordButtonTitleForSuccess() { | ||
| recoverPasswordButton.setTitle("Voltar", for: .normal) |
Owner
There was a problem hiding this comment.
n tem necessidade de uma funcao com 1 linha
ppedroam
reviewed
Feb 18, 2025
| try validateEmail(email) | ||
| try validateInternetConnection() | ||
|
|
||
| service.resetPassword(email: email) { [weak self] success in |
Owner
There was a problem hiding this comment.
usar async throws na funcao resetPassword da sua service
vai fazer com que essa funcao aqui fique muito mais limpa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lesson 2