Refactor: ResetPasswordViewController - ViewModel #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfoliveir4
commented
Feb 19, 2025
| success ? self.delegate?.showSuccess() : self.delegate?.showError( | ||
| "Algo de errado aconteceu. Tente novamente mais tarde." | ||
| ) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
salve salve @ppedroam !
Como a BadNetworkLayer.shared.resetPassword precisa de uma referencia pra viewModel fiquei com receio de criar a camada de service e passar uma referencia de viewController para a camada de serviço. Alguma sugestão?
Owner
There was a problem hiding this comment.
para solucionar isso deve se deixar de usar a BadNetworkLayer e começar usar os objetos da GoodNetworkLayer
Contributor
Author
|
salve salve @ppedroam ! Acha que vale também neste PR conter as alterações de view para viewCode? |
ppedroam
reviewed
Feb 19, 2025
| textLabel.text = "Ocorreu um erro inesperado" | ||
| } | ||
| extension LuzResetPasswordViewController: LuzResetPasswordViewModelDelegate { | ||
| func showError(_ message: String) { |
Owner
There was a problem hiding this comment.
show error what? alerta? melhorar nome
ppedroam
reviewed
Feb 19, 2025
| return [ | ||
| "email" : email | ||
| ] | ||
| func showSuccess() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apenas refatora e reset password view controller para separação de camadas