dhcpv6relay plugin: Add support for NA. #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For what it's worth: Already in production. |
Member
|
@paulusmack: Have you seen this @jkroonza PR? |
jkroonza
force-pushed
the
dhcpv6-na-support
branch
2 times, most recently
from
44b5414 to
5ed3ad3
Compare
jkroonza
commented
Oct 20, 2025
| switch (opttype) { | ||
| case DHCPv6_OPTION_IAPREFIX: | ||
| if (optlen < 9 || optlen < 9 + (bfr[8] + 7) / 8) { | ||
| error("DHCPv6 relay: IA_PD option from server needs at least 9 (up to 20) " |
Contributor
Author
There was a problem hiding this comment.
Ok, this needs fixing, bfr[8] is only available if optlen >=9.
Collaborator
There was a problem hiding this comment.
Right, the if is OK but the error() call needs to be more careful.
jkroonza
force-pushed
the
dhcpv6-na-support
branch
from
5ed3ad3 to
34e9785
Compare
Member
|
@paulusmack: @jkroonza has done the change quickly! :) |
As it turns out some (I won't mention names) routers ends up using LL addresses when originating IPv6 traffic in the absense of IA_NA issued address (In spite of having IA_PD space available). This allows the DHCPv6 server to issue same and have routing function. Include some extra safeties too for processing IA_PD server responses as well. Signed-off-by: Jaco Kroon <jaco@uls.co.za>
jkroonza
force-pushed
the
dhcpv6-na-support
branch
from
34e9785 to
45f13fa
Compare
Contributor
Author
|
That and fixed a typo in the validation checks that was copy&pasted back to IA_PD ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out some (I won't mention names) routers ends up using LL addresses when originating IPv6 traffic in the absense of IA_NA issued address (In spite of having IA_PD space available). This allows the DHCPv6 server to issue same and have routing function.