Replace <LicenseFile> with <LicenseExpression>#1279
Open
ulfllorenz wants to merge 1 commit intopraeclarum:masterfrom
Open
Replace <LicenseFile> with <LicenseExpression>#1279ulfllorenz wants to merge 1 commit intopraeclarum:masterfrom
ulfllorenz wants to merge 1 commit intopraeclarum:masterfrom
Conversation
Nuget effectively allows only one of the two, but using the expression had two advantages: 1. It is slightly easier to extract by tooling, because you need not query the github API for a possibly outdated license file. 2. It is recommended practice by Microsoft for standard licenses https://learn.microsoft.com/en-us/nuget/reference/nuspec#license
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nuget effectively allows only one of the two, but using the expression had two advantages:
This is far from the most urgent improvement. I just thought before I add a line in our internal tooling, I might in parallel spend a miniscule amount of time giving something back.