Add Contains method with StringComparison parameter.#806
Open
animha wants to merge 1 commit intopraeclarum:masterfrom
Open
Add Contains method with StringComparison parameter.#806animha wants to merge 1 commit intopraeclarum:masterfrom
animha wants to merge 1 commit intopraeclarum:masterfrom
Conversation
Managed to construct query with LIKE instead of instr() function for case-insensitive Contains.
|
Waiting for this 🥰 |
praeclarum
requested changes
May 16, 2020
Owner
praeclarum
left a comment
praeclarum
left a comment
There was a problem hiding this comment.
Looks great. I just want to get rid of the extra file. Please move your extension method into SQLite.cs. Thanks!
| /// <summary> | ||
| /// Class for Contains extension with StringComparison option | ||
| /// </summary> | ||
| public static class StringContainsExtension |
Owner
There was a problem hiding this comment.
Please rename to SQLiteStringExtensions and move it into the file SQLite.cs. Please delete this file.
|
Is there any chance that this feature will be added? |
Joy-less
added a commit
to Joy-less/SQLiteSharp
that referenced
this pull request
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing a TableQuery using "Contains" method, you always have a case-sensitive result, even if everything should work in a case-insensitive way.
This is due to the way the SELECT is constructed by the TableQuery class (now "instr" sqlite function is used, resulting always in a case-sensitive result).
I added an extension to Contains method, allowing developer to indicate which StringComparison option to use (like StartsWith/EndsWith method). If a case-insensitive option is specified, the sql code is constructed with LIKE instead of instr().