Adcluster Bid Adapter: Support Adcluster#14050
Adcluster Bid Adapter: Support Adcluster#14050adclusterdev wants to merge 9 commits intoprebid:masterfrom
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5655491193
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b7c28aa19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function detectMediaType(bid) { | ||
| if (bid.mediaType === "banner") return BANNER; | ||
| else if (bid.mediaType === "video") return VIDEO; | ||
| } |
There was a problem hiding this comment.
Fallback to banner when response omits mediaType
detectMediaType returns undefined unless the exchange explicitly sets mediaType, and interpretResponse only copies the creative payload in the banner/video branches. If the endpoint returns a banner bid without mediaType (a common response shape), the adapter drops b.ad and emits a bid with no renderable creative, which can still pass required-key validation and then fail at render time when it wins.
Useful? React with 👍 / 👎.
| if (mt.banner?.sizes?.length) { | ||
| imp.type = "banner"; | ||
| imp.width = mt.banner.sizes[0] && mt.banner.sizes[0][0]; | ||
| imp.height = mt.banner.sizes[0] && mt.banner.sizes[0][1]; | ||
| } else if (mt.video) { |
There was a problem hiding this comment.
Handle mixed banner/video requests without banner bias
The request builder hard-codes banner whenever both mediaTypes.banner and mediaTypes.video are present because the video branch is under else if. In multi-format ad units this silently strips video fields (playerSize, durations, video floor) and sends only a banner impression, so video demand is never requested for those placements.
Useful? React with 👍 / 👎.
Pull Request Test Coverage Report for Build 22238079374Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Contact: dev@adcluster.com.tr
Test Parameters - Banner:
Test Parameters - Video: