ReVantage Bid Adapter: initial release#14180
Conversation
Fixed trailing slash Error on Line 123
Fixed Trailing slashes (again)
same thing again
Refactor Revantage Bid Adapter to use media type constants and improve bid response handling.
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new ReVantage bidder adapter for Prebid.js, enabling publishers to receive bids from the ReVantage exchange. The adapter implements OpenRTB 2.x protocol with support for banner and video ad formats, including consent management (GDPR, CCPA, GPP) and win notification callbacks.
Key changes:
- New bidder adapter with OpenRTB request/response handling for banner and video formats
- Comprehensive test suite with 80+ test cases covering various scenarios
- Documentation with test parameters for integration validation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| modules/revantageBidAdapter.js | Core adapter implementation with bid validation, OpenRTB request building, response interpretation, user syncing, and win notification handling |
| test/spec/modules/revantageBidAdapter_spec.js | Test suite covering adapter functionality including validation, request building, response parsing, and user syncing |
| modules/revantageBidAdapter.md | Adapter documentation with module information and test parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/revantageBidAdapter.js
Outdated
| if (navigator.sendBeacon) { | ||
| const success = navigator.sendBeacon(bid.burl); | ||
|
|
||
| // Fallback to fetch if sendBeacon fails | ||
| if (!success) { | ||
| fetch(bid.burl, { | ||
| method: 'GET', | ||
| mode: 'no-cors', | ||
| cache: 'no-cache', | ||
| keepalive: true | ||
| }).catch(error => { | ||
| logError('Revantage: Win notification fetch failed', error); | ||
| }); | ||
| } | ||
| } else { | ||
| // Fallback for browsers without sendBeacon | ||
| fetch(bid.burl, { | ||
| method: 'GET', | ||
| mode: 'no-cors', | ||
| cache: 'no-cache', | ||
| keepalive: true | ||
| }).catch(error => { | ||
| logError('Revantage: Win notification fetch failed', error); | ||
| }); |
There was a problem hiding this comment.
There's duplicated fetch logic in the onBidWon function. Lines 163-171 and 174-181 contain nearly identical fetch calls. Consider extracting this into a helper function to reduce code duplication.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
2 similar comments
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
Added validation to ensure all bid requests in a batch have the same feedId, logging a warning if they do not.
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
|
Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):
|
|
Happy New Year Guys! |
|
@ncolletti @patmmccann can we merge this? |
|
@ncolletti please merge |
|
Can we please get a merge or atleast an Answer on this one? |
|
Hello? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e275c0837e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Happy 3 Month Wait-a-versary! Can we get a push? @ncolletti |
|
@v0idxyz you got a review from the bot, can you address? |
Added functions to handle video size extraction and VAST detection.
Added the changes! |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Contact: bern@revantage.io
Other information
prebid/prebid.github.io#6414