Skip to content

Comments

ReVantage Bid Adapter: initial release#14180

Open
v0idxyz wants to merge 28 commits intoprebid:masterfrom
v0idxyz:master
Open

ReVantage Bid Adapter: initial release#14180
v0idxyz wants to merge 28 commits intoprebid:masterfrom
v0idxyz:master

Conversation

@v0idxyz
Copy link

@v0idxyz v0idxyz commented Nov 20, 2025

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Contact: bern@revantage.io

Other information

prebid/prebid.github.io#6414

Copilot AI review requested due to automatic review settings November 20, 2025 19:36
@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a new ReVantage bidder adapter for Prebid.js, enabling publishers to receive bids from the ReVantage exchange. The adapter implements OpenRTB 2.x protocol with support for banner and video ad formats, including consent management (GDPR, CCPA, GPP) and win notification callbacks.

Key changes:

  • New bidder adapter with OpenRTB request/response handling for banner and video formats
  • Comprehensive test suite with 80+ test cases covering various scenarios
  • Documentation with test parameters for integration validation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.

File Description
modules/revantageBidAdapter.js Core adapter implementation with bid validation, OpenRTB request building, response interpretation, user syncing, and win notification handling
test/spec/modules/revantageBidAdapter_spec.js Test suite covering adapter functionality including validation, request building, response parsing, and user syncing
modules/revantageBidAdapter.md Adapter documentation with module information and test parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 158 to 181
if (navigator.sendBeacon) {
const success = navigator.sendBeacon(bid.burl);

// Fallback to fetch if sendBeacon fails
if (!success) {
fetch(bid.burl, {
method: 'GET',
mode: 'no-cors',
cache: 'no-cache',
keepalive: true
}).catch(error => {
logError('Revantage: Win notification fetch failed', error);
});
}
} else {
// Fallback for browsers without sendBeacon
fetch(bid.burl, {
method: 'GET',
mode: 'no-cors',
cache: 'no-cache',
keepalive: true
}).catch(error => {
logError('Revantage: Win notification fetch failed', error);
});
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's duplicated fetch logic in the onBidWon function. Lines 163-171 and 174-181 contain nearly identical fetch calls. Consider extracting this into a helper function to reduce code duplication.

Copilot uses AI. Check for mistakes.
v0idxyz and others added 3 commits November 20, 2025 20:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

2 similar comments
@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

Added validation to ensure all bid requests in a batch have the same feedId, logging a warning if they do not.
@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

@github-actions
Copy link

Tread carefully! This PR adds 10 linter errors (possibly disabled through directives):

  • modules/revantageBidAdapter.js (+10 errors)

@v0idxyz
Copy link
Author

v0idxyz commented Jan 22, 2026

Happy New Year Guys!

Copy link
Author

@v0idxyz v0idxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testfeed created

@v0idxyz
Copy link
Author

v0idxyz commented Jan 29, 2026

@ncolletti @patmmccann can we merge this?

@v0idxyz v0idxyz closed this Feb 2, 2026
@v0idxyz v0idxyz reopened this Feb 2, 2026
@v0idxyz v0idxyz closed this Feb 2, 2026
@v0idxyz v0idxyz reopened this Feb 2, 2026
@v0idxyz
Copy link
Author

v0idxyz commented Feb 6, 2026

@ncolletti please merge

@v0idxyz
Copy link
Author

v0idxyz commented Feb 9, 2026

Can we please get a merge or atleast an Answer on this one?

@v0idxyz
Copy link
Author

v0idxyz commented Feb 14, 2026

Hello?

@v0idxyz v0idxyz marked this pull request as draft February 14, 2026 21:33
@v0idxyz v0idxyz changed the title ReVantage Bid Adapter ReVantage Bid Adapter: initial release Feb 14, 2026
@v0idxyz v0idxyz marked this pull request as ready for review February 14, 2026 21:34
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e275c0837e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@v0idxyz
Copy link
Author

v0idxyz commented Feb 20, 2026

Happy 3 Month Wait-a-versary! Can we get a push? @ncolletti

@patmmccann
Copy link
Collaborator

@v0idxyz you got a review from the bot, can you address?

@patmmccann patmmccann self-assigned this Feb 20, 2026
Added functions to handle video size extraction and VAST detection.
@v0idxyz
Copy link
Author

v0idxyz commented Feb 21, 2026

@v0idxyz you got a review from the bot, can you address?

Added the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants