ID5 ID module: add option to use custom external targeting #14324
ID5 ID module: add option to use custom external targeting #14324patmmccann merged 10 commits intoprebid:masterfrom
Conversation
Add custom tag reporting mechanism for Id5IdSystem module See merge request id5-sync/Prebid.js!47
|
a public documentation PR prebid/prebid.github.io#6388 |
Type change in js-doc See merge request id5-sync/Prebid.js!50
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 366b6a9a00
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| window.googletag.cmd.push(() => { | ||
| for (const tag in tags) { | ||
| window.googletag.pubads().setTargeting(config.params.gamTargetingPrefix + '_' + tag, tags[tag]); | ||
| window.googletag.setConfig({targeting: {[config.params.gamTargetingPrefix + '_' + tag]: tags[tag]}}); |
There was a problem hiding this comment.
This replaces the standard GPT targeting call (googletag.pubads().setTargeting) with googletag.setConfig({targeting: ...}). In GPT, page-level targeting is set on the pubads service; setConfig is used for other GPT configuration (see existing uses like PPS in modules/gptPreAuction.ts) and doesn’t apply key/value targeting, so these tags won’t reach GAM when gamTargetingPrefix is enabled. This is a regression from the previous behavior and will break publishers relying on the GAM targeting tags.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Isn't pubads().setTargeting deprecated https://developers.google.com/publisher-tag/reference#googletag.PubAdsService.setTargeting ?
Also GPT Key-Value targeting page was updated to use setConfig https://developers.google.com/publisher-tag/guides/key-value-targeting
There was a problem hiding this comment.
@codex Isn't pubads().setTargeting deprecated https://developers.google.com/publisher-tag/reference#googletag.PubAdsService.setTargeting ?
Also GPT Key-Value targeting page was updated to use setConfig https://developers.google.com/publisher-tag/guides/key-value-targeting
There was a problem hiding this comment.
Codex couldn't complete this request. Try again later.
Pull Request Test Coverage Report for Build 21179635754Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
4 participants
Type of change
[x ] Feature
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added an option to set
exposeTargetingparam for ID5 module which, if provided, will cause the module to set appropriate external targeting tags for A/B testing purposes.Other information