Mile Bid Adapter: Initial release by shashankatd · Pull Request #14388 · prebid/Prebid.js

shashankatd · 2026-01-28T10:14:12Z

Type of change

Description of change

This PR introduces a new Mile bid adapter for Prebid.js, enabling publishers to access Mile demand sources.

Module Name: Mile Bid Adapter
Module Type: Bidder Adapter
Maintainer: tech@mile.tech

Other information

Prebid Dev Docs PR

github-actions · 2026-01-28T10:18:18Z

Tread carefully! This PR adds 98 linter errors (possibly disabled through directives):

modules/mileBidAdapter.ts (+92 errors)
test/spec/modules/mileBidAdapter_spec.js (+6 errors)

modules/mileBidAdapter.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4544783d98

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-01-28T12:37:19Z

modules/mileBidAdapter.ts

+    const sizes = deepAccess(bid, 'mediaTypes.banner.sizes');
+    sizes.forEach((size: string | number[]) => {


Guard banner sizes before iterating floors

When an ad unit uses the legacy sizes field instead of mediaTypes.banner.sizes (still supported in Prebid), deepAccess returns undefined and sizes.forEach(...) throws, aborting buildRequests and preventing any bids from being sent. This should defensively fall back to bid.sizes or an empty array before iterating so auctions with older configs don’t crash.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-28T12:37:19Z

modules/mileBidAdapter.ts

+    if (siteIdTracker === undefined) {
+      siteIdTracker = params.siteId;
+    } else if (siteIdTracker !== params.siteId) {
+      logError(`${BIDDER_CODE}: Site ID mismatch: ${siteIdTracker} !== ${params.siteId}`);
+      return false;


Avoid persisting site/publisher IDs across auctions

The module-scoped siteIdTracker/publisherIdTracker are set on the first valid bid and then used to reject later bids with different IDs; because these variables are never reset per auction, any SPA navigation or reconfiguration that changes siteId/publisherId will cause all subsequent Mile bids to be rejected. This silently drops demand in multi-tenant or multi-site setups and should be scoped to a single bidderRequest instead of global state.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-28T12:37:19Z

modules/mileBidAdapter.ts

+    ajax(MILE_ANALYTICS_ENDPOINT, null, JSON.stringify([winNotificationData]), { method: 'POST'});
+
+    // @ts-expect-error - bid.nurl is not defined
+    ajax(bid.nurl, null, null, { method: 'GET' });


Guard nurl call in onBidWon

bid.nurl is optional and only added when the server response includes it, but onBidWon calls ajax(bid.nurl, ...) unconditionally. If a winning bid lacks nurl, this passes undefined into ajax and will throw during request construction, breaking the win notification path. Check for bid.nurl before making the GET request.

Useful? React with 👍 / 👎.

github-actions · 2026-01-28T12:49:23Z

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

modules/mileBidAdapter.ts (+3 errors)

github-actions · 2026-01-28T12:49:31Z

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

modules/mileBidAdapter.ts (+3 errors)

coveralls · 2026-01-28T13:08:17Z

Pull Request Test Coverage Report for Build 21853777053

Details

403 of 411 (98.05%) changed or added relevant lines in 2 files are covered.
238 unchanged lines in 24 files lost coverage.
Overall coverage decreased (-0.01%) to 96.22%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/mileBidAdapter.ts	118	126	93.65%

Files with Coverage Reduction	New Missed Lines	%
modules/pubmaticBidAdapter.js	1	87.58%
modules/topLevelPaapi.js	1	98.97%
libraries/medianetUtils/logger.js	2	83.78%
libraries/percentInView/percentInView.js	2	93.75%
modules/beopBidAdapter.js	2	94.44%
modules/koblerBidAdapter.js	2	97.92%
test/spec/activities/objectGuard_spec.js	2	98.78%
test/spec/modules/id5IdSystem_spec.js	2	99.58%
src/secureCreatives.js	3	91.01%
test/spec/unit/secureCreatives_spec.js	3	99.0%

Totals
Change from base Build 21826065111:	-0.01%
Covered Lines:	209265
Relevant Lines:	217485

💛 - Coveralls

github-actions · 2026-01-30T08:00:31Z

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

test/spec/modules/mileBidAdapter_spec.js (+1 error)

github-actions · 2026-01-30T08:01:07Z

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

test/spec/modules/mileBidAdapter_spec.js (+1 error)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccc6d330a2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-02T06:48:31Z

modules/mileBidAdapter.ts

+      const sizes = deepAccess(bid, 'mediaTypes.banner.sizes') || [];
+      const floorPrice = getLowestFloorPrice(bid);
+
+      const imp: any = {
+        id: bid.bidId,


Populate banner format from legacy sizes

When an ad unit uses the legacy bid.sizes field (still supported in Prebid), deepAccess(bid, 'mediaTypes.banner.sizes') is undefined, so sizes becomes [] and the imp.banner.format array is empty. That yields an OpenRTB impression without any size information, which can cause Mile to reject the request or return no bids for legacy configs. Consider falling back to bid.sizes (or parseSizesInput) when mediaTypes.banner.sizes is absent.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-02T06:48:31Z

modules/mileBidAdapter.ts

+    // OpenRTB 2.5 response format: seatbid[] contains bid[]
+    const seatbids = response.bids || [];
+


Parse standard OpenRTB seatbid responses

The response parser is labeled as “OpenRTB 2.5”, but it reads bids from response.bids and iterates that directly. Standard OpenRTB uses seatbid[].bid[]; if the Mile endpoint returns a compliant OpenRTB response, this code will ignore all bids and yield an empty bidResponses array. To avoid silently dropping bids, parse response.seatbid (and the nested bid arrays) before building bid responses.

Useful? React with 👍 / 👎.

jsnellbaker

@shashankatd do you have any test params for your bidder that would return a test bid, so I can verify the adapter's e2e workflow?

shashankatd · 2026-02-05T11:20:16Z

@jsnellbaker I've updated the test parameters in mileBidAdapter.md. I've also added it below.

{
        bidder: 'mile',
        params: {
            placementId: 'test-placement-id',
            siteId: 'test-site-id',
            publisherId: 'test-publisher-id'
        }
}

jsnellbaker · 2026-02-06T15:33:35Z

Hi @shashankatd When I tried to use the test params on the hello_world test page, I saw the endpoint was returning a 404 error.

Can you please take a look?

Below is a copy of the URL and it's payload.
Url:
https://pbs.atmtd.com/mile/v1/request

Payload:

{"id":"f1a5a2b7-049c-4f1e-a0b4-9d8def008354","imp":[{"id":"c00cbe83-ff50-49cf-a003-aa50a1e70a6f","tagid":"test-placement-id","secure":1,"banner":{"format":[{"w":300,"h":250}]},"ext":{"adUnitCode":"div-gpt-ad-1460505748561-0","placementId":"test-placement-id","gpid":"/19968336/header-bid-tag-0"}}],"tmax":1000,"cur":["USD"],"site":{"id":"test-site-id","page":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","domain":"test.localhost:9999","ref":"","publisher":{"id":"test-publisher-id","domain":"test.localhost:9999"}},"user":{},"device":{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36","language":"en","dnt":0,"w":2560,"h":1440,"ext":{"vpw":2560,"vph":711},"sua":{"source":1,"platform":{"brand":"macOS"},"browsers":[{"brand":"Not(A:Brand","version":["8"]},{"brand":"Chromium","version":["144"]},{"brand":"Google Chrome","version":["144"]}],"mobile":0}},"source":{},"ext":{"prebid":{"channel":{"name":"pbjs","version":"10.25.0-pre"}}}}

krunchakravarthy · 2026-02-09T16:00:12Z

instead of test-site-id and test-placement-id , set test-site and test-placement in request-body.

{"id":"f1a5a2b7-049c-4f1e-a0b4-9d8def008354","imp":[{"id":"c00cbe83-ff50-49cf-a003-aa50a1e70a6f","tagid":"test-placement","secure":1,"banner":{"format":[{"w":300,"h":250}]},"ext":{"adUnitCode":"div-gpt-ad-1460505748561-0","placementId":"test-placement","gpid":"/19968336/header-bid-tag-0"}}],"tmax":1000,"cur":["USD"],"site":{"id":"test-site","page":"http://test.localhost:9999/integrationExamples/gpt/hello_world.html?pbjs_debug=true","domain":"test.localhost:9999","ref":"","publisher":{"id":"test-publisher","domain":"test.localhost:9999"}},"user":{},"device":{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36","language":"en","dnt":0,"w":2560,"h":1440,"ext":{"vpw":2560,"vph":711},"sua":{"source":1,"platform":{"brand":"macOS"},"browsers":[{"brand":"Not(A:Brand","version":["8"]},{"brand":"Chromium","version":["144"]},{"brand":"Google Chrome","version":["144"]}],"mobile":0}},"source":{},"ext":{"prebid":{"channel":{"name":"pbjs","version":"10.25.0-pre"}}}}

shashankatd · 2026-02-10T06:25:58Z

@jsnellbaker I have updated the test parameters in the mileBidderAdapter markdown file.

jsnellbaker

Thanks for the clarification, the other params did return a bid response.

review-assignment-bot bot requested a review from jsnellbaker January 28, 2026 10:16

github-advanced-security bot found potential problems Jan 28, 2026

View reviewed changes

modules/mileBidAdapter.ts Fixed Show fixed Hide fixed

shashankatd force-pushed the master branch from 479225e to 62c08e5 Compare January 28, 2026 10:23

shashankatd mentioned this pull request Jan 28, 2026

Mile Bidder Adapter: Initial Release prebid/prebid.github.io#6410

Open

8 tasks

shashankatd force-pushed the master branch 2 times, most recently from 79f53cf to 4544783 Compare January 28, 2026 12:10

shashankatd marked this pull request as ready for review January 28, 2026 12:34

chatgpt-codex-connector bot reviewed Jan 28, 2026

View reviewed changes

shashankatd force-pushed the master branch from fb3e294 to afb8a66 Compare January 28, 2026 12:45

shashankatd force-pushed the master branch from f00a575 to 6c10b3f Compare January 28, 2026 12:52

shashankatd force-pushed the master branch 4 times, most recently from 6096069 to a8f1479 Compare January 30, 2026 07:57

shashankatd force-pushed the master branch from a8f1479 to 8a2cdeb Compare January 30, 2026 08:04

shashankatd marked this pull request as draft January 30, 2026 08:28

shashankatd force-pushed the master branch from 8a2cdeb to ccc6d33 Compare February 2, 2026 06:35

shashankatd marked this pull request as ready for review February 2, 2026 06:46

chatgpt-codex-connector bot reviewed Feb 2, 2026

View reviewed changes

jsnellbaker requested changes Feb 3, 2026

View reviewed changes

shashankatd force-pushed the master branch from eb02c96 to 87ea227 Compare February 5, 2026 11:07

shashankatd force-pushed the master branch from 500d0f3 to 1f474ba Compare February 5, 2026 11:21

feat: Mile Bid Adapter - Initial release

ba8326e

shashankatd force-pushed the master branch from 1b81923 to ba8326e Compare February 10, 2026 06:06

jsnellbaker approved these changes Feb 11, 2026

View reviewed changes

jsnellbaker added the feature label Feb 11, 2026

jsnellbaker merged commit 4273a96 into prebid:master Feb 11, 2026
102 checks passed

		const sizes = deepAccess(bid, 'mediaTypes.banner.sizes');
		sizes.forEach((size: string \| number[]) => {

		// OpenRTB 2.5 response format: seatbid[] contains bid[]
		const seatbids = response.bids \|\| [];

Comments

Conversation

shashankatd commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

coveralls commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21853777053

Details

💛 - Coveralls

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

jsnellbaker left a comment

Choose a reason for hiding this comment

Uh oh!

shashankatd commented Feb 5, 2026

Uh oh!

jsnellbaker commented Feb 6, 2026

Uh oh!

krunchakravarthy commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shashankatd commented Feb 10, 2026

Uh oh!

jsnellbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shashankatd commented Jan 28, 2026 •

edited

Loading

coveralls commented Jan 28, 2026 •

edited

Loading

krunchakravarthy commented Feb 9, 2026 •

edited

Loading