Skip to content

Comments

Sevio bid adapter fallback natives#14390

Merged
robertrmartinez merged 5 commits intoprebid:masterfrom
Sevio:sevioBidAdapter_fallback_natives
Feb 11, 2026
Merged

Sevio bid adapter fallback natives#14390
robertrmartinez merged 5 commits intoprebid:masterfrom
Sevio:sevioBidAdapter_fallback_natives

Conversation

@petrican
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

In case that there is no type supplied we make a fallback to the id

Other information

@coveralls
Copy link
Collaborator

coveralls commented Jan 28, 2026

Pull Request Test Coverage Report for Build 21813792652

Details

  • 42 of 46 (91.3%) changed or added relevant lines in 2 files are covered.
  • 48 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+33.1%) to 96.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/sevioBidAdapter.js 14 18 77.78%
Files with Coverage Reduction New Missed Lines %
src/adloader.js 9 76.92%
src/utils.js 39 90.21%
Totals Coverage Status
Change from base Build #3: 33.1%
Covered Lines: 210444
Relevant Lines: 218696

💛 - Coveralls

@petrican
Copy link
Contributor Author

related legacy PR : #14390

@robertrmartinez
Copy link
Collaborator

related legacy PR : #14390

This is the same PR did you mean a different PR?

Please update and add unit tests to cover this also!

@petrican
Copy link
Contributor Author

petrican commented Feb 3, 2026

related legacy PR : #14390

This is the same PR did you mean a different PR?

Please update and add unit tests to cover this also!

This #14390 is the PR that targets the master branch. I added tests here too. The other PR is #14391 (that one targets legacy branch 9.53.x-legacy - as we have clients using that specific branch). Thanks!

@petrican
Copy link
Contributor Author

Hi @robertrmartinez ! Can you help me with this PR too? Thanks!

@robertrmartinez robertrmartinez merged commit f7c34c3 into prebid:master Feb 11, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants