Skip to content

Comments

TargetVideo bid adapter: send price floor param#14406

Merged
robertrmartinez merged 6 commits intoprebid:masterfrom
danijel-ristic:upgrade/floor-price-param
Feb 20, 2026
Merged

TargetVideo bid adapter: send price floor param#14406
robertrmartinez merged 6 commits intoprebid:masterfrom
danijel-ristic:upgrade/floor-price-param

Conversation

@danijel-ristic
Copy link
Contributor

@danijel-ristic danijel-ristic commented Feb 3, 2026

Type of change

  • Updated bidder adapter

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Related PR #6418

@coveralls
Copy link
Collaborator

coveralls commented Feb 3, 2026

Pull Request Test Coverage Report for Build 22222891463

Details

  • 18 of 22 (81.82%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 96.262%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/targetVideoBidAdapter.js 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
modules/kinessoIdSystem.js 1 83.15%
test/spec/creative/crossDomainCreative_spec.js 1 93.75%
test/spec/modules/id5AnalyticsAdapter_spec.js 1 96.13%
Totals Coverage Status
Change from base Build 22149413522: -0.002%
Covered Lines: 212399
Relevant Lines: 220647

💛 - Coveralls

@danijel-ristic
Copy link
Contributor Author

@robertrmartinez Hi Robert, any progress on this?

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi a rule for Bid Adapters is if you accept a floor from a param you must support the price floors module getFloor function

- Adapters that accept a floor parameter must also support the [floors module](https://docs.prebid.org/dev-docs/modules/floors.html) -- look for a call to the `getFloor()` function.

And example of how this is usually supported:

https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L1325-L1339

and you can fallback to param floor if not found.

Let me know if that makes sense!

@github-actions
Copy link

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/targetVideoBidAdapter.js (+2 errors)

@danijel-ristic
Copy link
Contributor Author

I added changes you suggested, can you tell me if everything is good now? I see one test is failing but it's during CI setup I would say.

@danijel-ristic
Copy link
Contributor Author

@robertrmartinez Any progress on this?

@robertrmartinez
Copy link
Collaborator

so only want to pass floor for video imps? not banner?

@robertrmartinez robertrmartinez merged commit ebb775c into prebid:master Feb 20, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants