TargetVideo bid adapter: send price floor param#14406
TargetVideo bid adapter: send price floor param#14406robertrmartinez merged 6 commits intoprebid:masterfrom
Conversation
Pull Request Test Coverage Report for Build 22222891463Details
💛 - Coveralls |
|
@robertrmartinez Hi Robert, any progress on this? |
robertrmartinez
left a comment
There was a problem hiding this comment.
Hi a rule for Bid Adapters is if you accept a floor from a param you must support the price floors module getFloor function
Line 57 in f7c34c3
And example of how this is usually supported:
https://github.com/prebid/Prebid.js/blob/master/modules/appnexusBidAdapter.js#L1325-L1339
and you can fallback to param floor if not found.
Let me know if that makes sense!
|
Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):
|
|
I added changes you suggested, can you tell me if everything is good now? I see one test is failing but it's during CI setup I would say. |
|
@robertrmartinez Any progress on this? |
|
so only want to pass floor for video imps? not banner? |
Type of change
Updated bidder adapter
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Related PR #6418