Draft
Conversation
* Remove quantcastIdSystem. * Remove references to quantcastId. --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
* Remove quantcast bid adapter. * Update metadata. * Update modules.json * Add quantcastBidAdapter.json metadata file --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com> Co-authored-by: Patrick McCann <pmccann@cafemedia.com>
* core: remove paapi support * PAAPI: remove paapi modules * Core: remove getBidToRender * Debugging: remove paapi support * Core: remove paapi events * PBS bid adapter: remove paapi support * VidazooUtils: remove paapi support * paapiTools: remove paapiTools * remove stray references to paapi methods * criteo bid adapter: remove paapi support * ix bid adapter: remove paapi support * logicAd bid adapter: remove paapi support * gumgum bid adapter: remove paapi support * ccx bid adapter: remove paapi support * Remove stray paapi tests * kargo bid adapter: remove paapi support * rtb house bid adapter: remove references to fledge in docs * onetag bid adapter: remove paapi support * medianet bid adapter: remove paapi support * lucead bid adapter: remove paapi support * openxBidAdapter: remove paapi support * optable bid adapter: remove paapi support * sharethrough bid adapter: remove paapi support * silverpush bid adapter: remove paapi support * sspBC bid adapter: remove paapi support * taboola bid adapter: remove paapi support * triplelift bid adapter: remove paapi support * ozone bid adapter: remove paapi support * lint * Delete modules/optableBidAdapter.js * Delete modules/optableBidAdapter.md * Delete test/spec/modules/optableBidAdapter_spec.js --------- Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Collaborator
Pull Request Test Coverage Report for Build 21946526979Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2bb76e1f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* Core: remove dead adpod code paths from appnexus and mediafuse * Delete libraries/categoryTranslationMapping/index.js * Delete modules/categoryTranslation.js * Delete metadata/modules/categoryTranslation.json * Delete test/spec/modules/categoryTranslation_spec.js * Delete metadata/disclosures/prebid/categoryTranslation.json * Remove notifyTranslationModule and its hook registration Removed notifyTranslationModule function and its registration. * Remove brand category exclusion from payload Removed brand category uniqueness setting from payload. * Remove brand category uniqueness from payload Removed brand category uniqueness setting from payload. * Update appnexusBidAdapter_spec.js * Update mediafuseBidAdapter_spec.js * Update gamAdServerVideo.js * Update test_deps.js * Adapters: remove adpod media type handling across bidders (#14456) * Update aidemBidAdapter.js * Update aidemBidAdapter_spec.js
…hange (#14462) * 33across ID Adapter: stabilize hashed email cleanup test * 33across Id System: gate HEM persistence on storeFpid * Update 33acrossIdSystem.js
* Prebid 11: turn off storageControl during testing * remove unnecessary setConfig
…ion (#14466) * Core: remove addAdUnits event emission * Core: remove analytics subscriptions for addAdUnits * Core: remove addAdUnits event constant * Core: remove seatNonBid event constant * 33across Analytics Adapter: handle seatnonbid via pbsAnalytics (#14471) * Update 33acrossAnalyticsAdapter.js * Update 33acrossAnalyticsAdapter_spec.js
…t handling (#14448) * Fix data formatting in gmosspBidAdapter tests * Remove DNT signal handling from bid request Removed deprecated DNT signal handling from request. * Update video startdelay, skip, and bidfloor values * Update viewability checks to expect 0 instead of null * Update video startdelay and skip expectations * Update bidfloor and no bid response expectations * Remove dnt test case from rhythmoneBidAdapter_spec Removed test case for 'dnt is correctly set to 1' in rhythmoneBidAdapter_spec.js. * Update video startdelay and skip expectations * Update mileBidAdapter.ts * OpenX Adapter: restore getDNT usage for dnt field (#14472) * Core: restore getDNT payload mapping across adapters (#14474) * Update displayioBidAdapter.js * Update mediakeysBidAdapter.js * Update openxBidAdapter.js * Update yahooAdsBidAdapter.js * Update yieldmoBidAdapter.js * Update yieldmoBidAdapter_spec.js * Update enrichment.ts * Update openxBidAdapter.js * Update trafficgateBidAdapter_spec.js * Update trafficgateBidAdapter_spec.js * Update trafficgateBidAdapter_spec.js * Update trafficgateBidAdapter.js * Update trafficgateBidAdapter.js * Do not add DNT to adapters that don't care about it * linter --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes all issues tagged 11.0 Api change.