Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd2a6198ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| isBidRequestValid: isBidRequestValid(), | ||
| buildRequests: buildRequests(AD_URL), | ||
| interpretResponse, | ||
| getUserSyncs: getUserSyncs(SYNC_URL) |
There was a problem hiding this comment.
Wiring getUserSyncs: getUserSyncs(SYNC_URL) here pulls in the teqblaze helper that only appends CCPA when uspConsent.consentString exists, but registerSyncs passes bidderRequest.uspConsent directly from the bidder request (a raw USP string in Prebid), so in real auctions this adapter’s sync URL will omit ccpa_consent even when USP consent is available. This can send sync traffic without the expected privacy signal in CCPA flows.
Useful? React with 👍 / 👎.
Pull Request Test Coverage Report for Build 21954470584Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
2 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
Docs: prebid/prebid.github.io#6427