Openx bid adapter: WIP deduplicate request by marcin-wrobel-ox · Pull Request #14477 · prebid/Prebid.js

marcin-wrobel-ox · 2026-02-13T15:40:00Z

Type of change

Description of change

Other information

Copilot

Pull request overview

This PR refactors the OpenX bid adapter to consolidate multiple bid requests into a single HTTP request, improving performance by reducing network overhead. Previously, the adapter would send separate HTTP requests for video bids versus banner/native bids. With this change, all bid requests are combined into a single HTTP request with multiple impressions.

Changes:

Simplified request building logic to create one HTTP request for all bid types
Removed mediaType context parameter to allow ortbConverter to generate all media type objects in impressions
Updated test expectations to validate single request with multiple impressions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
modules/openxBidAdapter.js	Simplified buildRequests to return single consolidated request; removed helper functions for bid type detection and mediaType parameter
test/spec/modules/openxBidAdapter_spec.js	Updated tests to expect 1 request with multiple impressions instead of multiple requests; added mtype field to video response fixtures; added new tests for consolidated request behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T15:45:09Z

test/spec/modules/openxBidAdapter_spec.js

                crid: 'test-creative-id',
                dealid: 'test-deal-id',
                adm: '<VAST version="4.0"><Ad></Ad></VAST>',
+                mtype: 2,


The PR title indicates this is a "WIP" (Work In Progress). However, the code changes appear complete with proper test coverage. Please update the PR title to remove "WIP" if this is ready for review, or clarify what remaining work is needed before this can be merged.

Copilot · 2026-02-13T15:45:10Z

modules/openxBidAdapter.js


 function buildRequests(bidRequests, bidderRequest) {


The simplified request consolidation now uses only the first bid request's parameters for request-level fields (platform, delDomain, coppa, doNotTrack, response_template_name, test - see lines 60-78 of the converter configuration). If different bid requests specify different values for these parameters, only the first request's values will be used. Consider validating that all bid requests have consistent request-level parameters, or document this limitation so publishers understand these parameters must be consistent across all ad units in an auction.

Suggested change

function buildRequests(bidRequests, bidderRequest) {

/**

* Validate that all bidRequests use consistent values for request-level parameters.

* The OpenRTB converter uses only the first bidRequest's values for these fields.

* This function logs a warning when inconsistencies are detected so publishers are

* aware that parameters must be consistent across all ad units in an auction.

*

* @param {Array} bidRequests

*/

function validateRequestLevelParamsConsistency(bidRequests) {

if (!Array.isArray(bidRequests) || bidRequests.length < 2) {

return;

}

const fields = ['platform', 'delDomain', 'coppa', 'doNotTrack', 'response_template_name', 'test'];

const baseRequest = bidRequests[0] || {};

const baseParams = baseRequest.params || {};

for (let i = 1; i < bidRequests.length; i++) {

const currentRequest = bidRequests[i] || {};

const currentParams = currentRequest.params || {};

fields.forEach(field => {

if (baseParams[field] !== currentParams[field]) {

utils.logWarn(

`OpenX: inconsistent request-level parameter "${field}" between ad units. ` +

'The value from the first ad unit will be used for the OpenRTB request.'

);

}

});

}

}

function buildRequests(bidRequests, bidderRequest) {

validateRequestLevelParamsConsistency(bidRequests);

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 719568da26

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-13T15:45:13Z

modules/openxBidAdapter.js

-    requests.push(createRequest([bid], bidderRequest, VIDEO));
-  });
-  return requests;
+  return [createRequest(bidRequests, bidderRequest)];


Do not batch bids that need distinct request-level params

This change forces every OpenX bid into one ORTB request, but the request builder still reads coppa, doNotTrack, platform, delDomain, and response_template_name from only context.bidRequests[0]. As a result, when an auction contains multiple OpenX bids with different request-level params (for example different delDomain/platform or privacy flags), all non-first bids inherit the first bid’s settings; previously video bids were isolated into their own requests and kept their own params.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-13T15:45:13Z

modules/openxBidAdapter.js

    method: 'POST',
    url: config.getConfig('openxOrtbUrl') || REQUEST_URL,
-    data: converter.toORTB({bidRequests, bidderRequest, context: {mediaType}})
+    data: converter.toORTB({bidRequests, bidderRequest})


Keep mediaType context when converting video requests

Removing the context.mediaType argument from converter.toORTB means response parsing can no longer fall back to a known media type for video requests. In setResponseMediaType, if a bid response lacks seatbid.bid[].mtype (common in ORTB 2.5-style responses), the converter throws and the bid is skipped; this path was previously avoided by sending video requests with context.mediaType = 'video'.

Useful? React with 👍 / 👎.

WIP deduplicate request

719568d

Copilot AI review requested due to automatic review settings February 13, 2026 15:40

marcin-wrobel-ox marked this pull request as draft February 13, 2026 15:40

Copilot started reviewing on behalf of marcin-wrobel-ox February 13, 2026 15:40 View session

review-assignment-bot bot requested a review from robertrmartinez February 13, 2026 15:42

Copilot AI reviewed Feb 13, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 13, 2026

View reviewed changes

patmmccann changed the title ~~WIP deduplicate request~~ Openx bid adapter: WIP deduplicate request Feb 17, 2026

bukrain added 4 commits February 20, 2026 08:21

Cleanup of tests and buildRequest function

a9c8b43

Improve tests

27eff87

Revert changing platformID in test

a5e7778

Add additional tests

13172aa

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Openx bid adapter: WIP deduplicate request#14477

Openx bid adapter: WIP deduplicate request#14477
marcin-wrobel-ox wants to merge 5 commits intoprebid:masterfrom
openx:wip-dedup-requests

marcin-wrobel-ox commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-function buildRequests(bidRequests, bidderRequest) {
+/**
+ * Validate that all bidRequests use consistent values for request-level parameters.
+ * The OpenRTB converter uses only the first bidRequest's values for these fields.
+ * This function logs a warning when inconsistencies are detected so publishers are
+ * aware that parameters must be consistent across all ad units in an auction.
+ *
+ * @param {Array} bidRequests
+ */
+function validateRequestLevelParamsConsistency(bidRequests) {
+  if (!Array.isArray(bidRequests) || bidRequests.length < 2) {
+    return;
+  }
+  const fields = ['platform', 'delDomain', 'coppa', 'doNotTrack', 'response_template_name', 'test'];
+  const baseRequest = bidRequests[0] || {};
+  const baseParams = baseRequest.params || {};
+  for (let i = 1; i < bidRequests.length; i++) {
+    const currentRequest = bidRequests[i] || {};
+    const currentParams = currentRequest.params || {};
+    fields.forEach(field => {
+      if (baseParams[field] !== currentParams[field]) {
+        utils.logWarn(
+          `OpenX: inconsistent request-level parameter "${field}" between ad units. ` +
+          'The value from the first ad unit will be used for the OpenRTB request.'
+        );
+      }
+    });
+  }
+}
+function buildRequests(bidRequests, bidderRequest) {
+  validateRequestLevelParamsConsistency(bidRequests);

Comments

Conversation

marcin-wrobel-ox commented Feb 13, 2026

Type of change

Description of change

Other information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants