Skip to content

Comments

Taboola: support native#14486

Open
ronishefi9 wants to merge 24 commits intoprebid:masterfrom
taboola:taboola-support-native
Open

Taboola: support native#14486
ronishefi9 wants to merge 24 commits intoprebid:masterfrom
taboola:taboola-support-native

Conversation

@ronishefi9
Copy link

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Added support in the Taboola adapter for native ads.

Other information

talavital7 and others added 24 commits November 26, 2025 15:07
add deferredBilling support using onBidBillable
use Prebid's built-in counters for refresh signals
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4cad25d142

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

return hasBanner || hasNative;
},
buildRequests: (validBidRequests, bidderRequest) => {
const [bidRequest] = validBidRequests;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Split requests by media type before choosing endpoint

buildRequests picks the endpoint from only the first bid (validBidRequests[0]) but still converts and submits the full validBidRequests array in one ORTB payload. In auctions that include both Taboola banner and native ad units, this sends one media type to the wrong host (display... or native...), which can drop bids for whichever type doesn’t match the chosen URL.

Useful? React with 👍 / 👎.

Comment on lines +186 to +187
const { mediaType } = getMediaType(context.bidRequest);
context.mediaType = mediaType;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve ORTB mtype when decoding mixed-format responses

The response converter unconditionally sets context.mediaType from the original bid request, and getMediaType resolves mixed banner+native requests to banner. That overrides the default ORTB media-type detection from bid.mtype, so native bids returned for mixed-format requests are interpreted as banner (missing native.ortb and getting banner ad handling instead).

Useful? React with 👍 / 👎.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ronishefi9 this seems like a significant issue, much of your native demand will be multiformat

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22141377152

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 65 of 66 (98.48%) changed or added relevant lines in 2 files are covered.
  • 206 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.04%) to 96.221%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/taboolaBidAdapter.js 24 25 96.0%
Files with Coverage Reduction New Missed Lines %
modules/pubmaticBidAdapter.js 1 87.58%
libraries/percentInView/percentInView.js 2 93.75%
modules/beopBidAdapter.js 2 94.44%
modules/koblerBidAdapter.js 2 97.92%
test/spec/activities/objectGuard_spec.js 2 98.78%
test/spec/modules/id5IdSystem_spec.js 2 99.58%
modules/missenaBidAdapter.js 4 91.94%
modules/optidigitalBidAdapter.js 4 95.74%
modules/sovrnBidAdapter.js 4 93.57%
modules/limelightDigitalBidAdapter.js 9 84.75%
Totals Coverage Status
Change from base Build 22104747075: -0.04%
Covered Lines: 209223
Relevant Lines: 217441

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants