Conversation
add deferredBilling support using onBidBillable
Taboola support extra signals
use Prebid's built-in counters for refresh signals
updated detectBot logic
…g banner support. Added and updated tests.
…g banner support. Added and updated tests.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cad25d142
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return hasBanner || hasNative; | ||
| }, | ||
| buildRequests: (validBidRequests, bidderRequest) => { | ||
| const [bidRequest] = validBidRequests; |
There was a problem hiding this comment.
Split requests by media type before choosing endpoint
buildRequests picks the endpoint from only the first bid (validBidRequests[0]) but still converts and submits the full validBidRequests array in one ORTB payload. In auctions that include both Taboola banner and native ad units, this sends one media type to the wrong host (display... or native...), which can drop bids for whichever type doesn’t match the chosen URL.
Useful? React with 👍 / 👎.
| const { mediaType } = getMediaType(context.bidRequest); | ||
| context.mediaType = mediaType; |
There was a problem hiding this comment.
Preserve ORTB mtype when decoding mixed-format responses
The response converter unconditionally sets context.mediaType from the original bid request, and getMediaType resolves mixed banner+native requests to banner. That overrides the default ORTB media-type detection from bid.mtype, so native bids returned for mixed-format requests are interpreted as banner (missing native.ortb and getting banner ad handling instead).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@ronishefi9 this seems like a significant issue, much of your native demand will be multiformat
Pull Request Test Coverage Report for Build 22141377152Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added support in the Taboola adapter for native ads.
Other information