Magnite Bid Adapter: convert to ts#14487
Closed
patmmccann wants to merge 3 commits intoMagniteBidAdapterfrom
Closed
Magnite Bid Adapter: convert to ts#14487patmmccann wants to merge 3 commits intoMagniteBidAdapterfrom
patmmccann wants to merge 3 commits intoMagniteBidAdapterfrom
Conversation
Collaborator
|
I am not a fan of converting to ts just to say we did it when majority of the file is just Let me do this locally and push to my branch and see if I can find necessary types or make new ones |
Collaborator
Author
|
I agree, maybe i can fill in some of those types. I'm hoping we can disallow new modules in js in Prebid 11, what do you think? |
Collaborator
Author
|
@robertrmartinez this should be closer now |
Collaborator
Pull Request Test Coverage Report for Build 22149336013Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branches off #14476 to make the new adatper ts