Skip to content

Comments

Magnite Bid Adapter: convert to ts#14487

Closed
patmmccann wants to merge 3 commits intoMagniteBidAdapterfrom
codex/convert-magnitebidadapter.js-to-typescript
Closed

Magnite Bid Adapter: convert to ts#14487
patmmccann wants to merge 3 commits intoMagniteBidAdapterfrom
codex/convert-magnitebidadapter.js-to-typescript

Conversation

@patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented Feb 18, 2026

branches off #14476 to make the new adatper ts

@patmmccann patmmccann changed the title Codex-generated pull request Magnite Bid Adapter: convert to ts Feb 18, 2026
@robertrmartinez
Copy link
Collaborator

I am not a fan of converting to ts just to say we did it when majority of the file is just any types.

Let me do this locally and push to my branch and see if I can find necessary types or make new ones

@patmmccann
Copy link
Collaborator Author

I agree, maybe i can fill in some of those types. I'm hoping we can disallow new modules in js in Prebid 11, what do you think?

@patmmccann
Copy link
Collaborator Author

@robertrmartinez this should be closer now

@patmmccann patmmccann closed this Feb 18, 2026
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 22149336013

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 96.27%

Files with Coverage Reduction New Missed Lines %
libraries/medianetUtils/logger.js 2 83.78%
Totals Coverage Status
Change from base Build 22121151274: -0.001%
Covered Lines: 212991
Relevant Lines: 221243

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants