pubstackBidAdapter: initial release by gpolaert · Pull Request #14490 · prebid/Prebid.js

gpolaert · 2026-02-18T21:12:02Z

Type of change

Description of change

Other information

* feat: add SparkBidAdapter * fix: reviews * fix: use iframe for user_sync * fix: change adapter name * fix: add test file * feat: add viewport value in imp[].ext.prebid.bidder.pubstack.vpl * fix: remove unused context * Pubstack Adapter: update utils and align adapter tests * Pubstack Bid Adapter: apply lint-driven TypeScript cleanups --------- Co-authored-by: gpolaert <gpolaert@pubstack.io>

Copilot

Pull request overview

This PR introduces a new Pubstack bidder adapter for Prebid.js, enabling publishers to integrate with the Pubstack exchange for header bidding.

Changes:

Added a new TypeScript bid adapter module (pubstackBidAdapter.ts) that supports banner, video, and native ad formats
Created a utility library (pubstackUtils) for viewport distance calculation and page visibility detection
Added comprehensive test coverage for both the adapter and utility functions
Updated metadata to register the new bidder with GVLID 1408

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
modules/pubstackBidAdapter.ts	Main bid adapter implementing ORTB conversion, bid validation, request building, and user sync
modules/pubstackBidAdapter.md	Documentation and test parameters for the Pubstack adapter
libraries/pubstackUtils/index.ts	Utility functions for element location, viewport distance calculation, and page visibility
test/spec/modules/pubstackBidAdapter_spec.js	Unit tests for the Pubstack bid adapter
test/spec/libraries/pubstackUtils_spec.js	Unit tests for the Pubstack utility library
metadata/modules.json	Registration of Pubstack bidder in module metadata

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

modules/pubstackBidAdapter.ts

Copilot · 2026-02-18T21:15:54Z

modules/pubstackBidAdapter.ts

+    deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);
+    deepSetValue(request, `ext.prebid.cntImp`, cntImp);
+    deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())
+    deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))


Missing semicolon at the end of the statement. The code style should be consistent with the surrounding code which uses semicolons to terminate statements.

modules/pubstackBidAdapter.md

libraries/pubstackUtils/index.ts

modules/pubstackBidAdapter.ts

Copilot · 2026-02-18T21:15:55Z

modules/pubstackBidAdapter.ts

+    const request = buildRequest(imps, bidderRequest, context)
+    const siteId = bidderRequest.bids[0].params.siteId
+    siteIds.add(siteId);
+    deepSetValue(request, 'site.publisher.id', siteId)
+    deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0)
+    deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');
+    deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);
+    deepSetValue(request, `ext.prebid.cntImp`, cntImp);
+    deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())
+    deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))


Missing semicolon at the end of the statement. The code style should be consistent with the surrounding code which uses semicolons to terminate statements.

Suggested change

const request = buildRequest(imps, bidderRequest, context)

const siteId = bidderRequest.bids[0].params.siteId

siteIds.add(siteId);

deepSetValue(request, 'site.publisher.id', siteId)

deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0)

deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');

deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);

deepSetValue(request, `ext.prebid.cntImp`, cntImp);

deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())

deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))

const request = buildRequest(imps, bidderRequest, context);

const siteId = bidderRequest.bids[0].params.siteId;

siteIds.add(siteId);

deepSetValue(request, 'site.publisher.id', siteId);

deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0);

deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');

deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);

deepSetValue(request, `ext.prebid.cntImp`, cntImp);

deepSetValue(request, `ext.prebid.pVisible`, isPageVisible());

deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000));

Copilot · 2026-02-18T21:15:56Z

modules/pubstackBidAdapter.ts

+    const request = buildRequest(imps, bidderRequest, context)
+    const siteId = bidderRequest.bids[0].params.siteId
+    siteIds.add(siteId);
+    deepSetValue(request, 'site.publisher.id', siteId)
+    deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0)
+    deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');
+    deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);
+    deepSetValue(request, `ext.prebid.cntImp`, cntImp);
+    deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())
+    deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))


Missing semicolon at the end of the statement. The code style should be consistent with the surrounding code which uses semicolons to terminate statements.

Suggested change

const request = buildRequest(imps, bidderRequest, context)

const siteId = bidderRequest.bids[0].params.siteId

siteIds.add(siteId);

deepSetValue(request, 'site.publisher.id', siteId)

deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0)

deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');

deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);

deepSetValue(request, `ext.prebid.cntImp`, cntImp);

deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())

deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))

const request = buildRequest(imps, bidderRequest, context);

const siteId = bidderRequest.bids[0].params.siteId;

siteIds.add(siteId);

deepSetValue(request, 'site.publisher.id', siteId);

deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0);

deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');

deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);

deepSetValue(request, `ext.prebid.cntImp`, cntImp);

deepSetValue(request, `ext.prebid.pVisible`, isPageVisible());

deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000));

Copilot · 2026-02-18T21:15:56Z

modules/pubstackBidAdapter.ts

+    const request = buildRequest(imps, bidderRequest, context)
+    const siteId = bidderRequest.bids[0].params.siteId
+    siteIds.add(siteId);
+    deepSetValue(request, 'site.publisher.id', siteId)
+    deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0)
+    deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');
+    deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);
+    deepSetValue(request, `ext.prebid.cntImp`, cntImp);
+    deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())
+    deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))


Missing semicolon at the end of the statement. The code style should be consistent with the surrounding code which uses semicolons to terminate statements.

Suggested change

const request = buildRequest(imps, bidderRequest, context)

const siteId = bidderRequest.bids[0].params.siteId

siteIds.add(siteId);

deepSetValue(request, 'site.publisher.id', siteId)

deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0)

deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');

deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);

deepSetValue(request, `ext.prebid.cntImp`, cntImp);

deepSetValue(request, `ext.prebid.pVisible`, isPageVisible())

deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000))

const request = buildRequest(imps, bidderRequest, context);

const siteId = bidderRequest.bids[0].params.siteId;

siteIds.add(siteId);

deepSetValue(request, 'site.publisher.id', siteId);

deepSetValue(request, 'test', config.getConfig('debug') ? 1 : 0);

deepSetValue(request, 'ext.prebid.version', getGlobal()?.version ?? 'unknown');

deepSetValue(request, `ext.prebid.cntRequest`, cntRequest);

deepSetValue(request, `ext.prebid.cntImp`, cntImp);

deepSetValue(request, `ext.prebid.pVisible`, isPageVisible());

deepSetValue(request, `ext.prebid.uStart`, Math.trunc((performance.now() - uStart) / 1000));

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f879844b3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-18T21:29:12Z

modules/pubstackBidAdapter.ts

+  request(buildRequest, imps, bidderRequest, context) {
+    cntRequest++;
+    const request = buildRequest(imps, bidderRequest, context)
+    const siteId = bidderRequest.bids[0].params.siteId


Preserve each bid's siteId when building batched requests

buildRequests receives all valid bids for the auction, but the request customizer always reads bidderRequest.bids[0].params.siteId and applies that single value to the whole ORTB request. When an auction contains multiple pubstack bids with different siteId values, every imp after the first is sent under the wrong publisher context (site.publisher.id and ?siteId=), which can misroute or reject those bids.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-02-18T21:29:12Z

modules/pubstackBidAdapter.ts

+
+  return Array.from(siteIds).map(siteId => ({
+    type: isIframeEnabled ? 'iframe' : 'image',
+    url: `${syncUrl}?consent=${payload}&siteId=${siteId}`,


Encode consent payload before appending to sync URL

The sync URL concatenates raw Base64 into consent= without URL-encoding it. Base64 output can contain +, and common query parsers decode + as a space, so the consent blob arrives corrupted and may fail to decode on the usersync endpoint, causing sync failures for affected consent strings.

Useful? React with 👍 / 👎.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

gpolaert · 2026-02-18T21:34:51Z

I ran the ESLint, but I still have semicolon and formatting issues. How can I configure it and add it as a hook before committing the files to avoid being spammed by Codex/Copilot?

coveralls · 2026-02-18T21:48:47Z

Pull Request Test Coverage Report for Build 22158457780

Details

313 of 313 (100.0%) changed or added relevant lines in 4 files are covered.
4 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.004%) to 96.268%

Files with Coverage Reduction	New Missed Lines	%
modules/excoBidAdapter.js	1	78.17%
modules/kinessoIdSystem.js	1	83.15%
test/spec/creative/crossDomainCreative_spec.js	1	93.75%
test/spec/modules/id5AnalyticsAdapter_spec.js	1	96.13%

Totals
Change from base Build 22149413522:	0.004%
Covered Lines:	212695
Relevant Lines:	220940

💛 - Coveralls

patmmccann · 2026-02-20T19:16:01Z

libraries/pubstackUtils/index.ts

+  if (element) return element;
+};
+
+export const getViewportDistance = (adUnitCode?: string): number | undefined => {


we just added another library for this, let us know if you can use that or if it needs modifications

patmmccann

please look into the other library - https://github.com/prebid/Prebid.js/blob/master/libraries/placementPositionInfo/placementPositionInfo.js

patmmccann · 2026-02-20T19:21:12Z

I ran the ESLint, but I still have semicolon and formatting issues. How can I configure it and add it as a hook before committing the files to avoid being spammed by Codex/Copilot?

only copilot is complaining about your styling and I agree with it, while you do pass linting it looks strange to randomly omit semicolons on some lines

Copilot AI review requested due to automatic review settings February 18, 2026 21:12

Copilot started reviewing on behalf of gpolaert February 18, 2026 21:12 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

review-assignment-bot bot requested review from mkomorski and ncolletti February 18, 2026 21:16

gpolaert mentioned this pull request Feb 18, 2026

Add Pubstack bidder documentation (#1) prebid/prebid.github.io#6438

Open

8 tasks

chatgpt-codex-connector bot reviewed Feb 18, 2026

View reviewed changes

gpolaert and others added 4 commits February 18, 2026 22:30

Update modules/pubstackBidAdapter.ts

bb4d729

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update modules/pubstackBidAdapter.md

c75ced9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update libraries/pubstackUtils/index.ts

17ec281

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update modules/pubstackBidAdapter.ts

6bc82fe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

patmmccann reviewed Feb 20, 2026

View reviewed changes

patmmccann requested changes Feb 20, 2026

View reviewed changes

patmmccann self-assigned this Feb 20, 2026

patmmccann added the feature label Feb 20, 2026

patmmccann changed the title ~~feat: add pubstackBidAdapter (#1)~~ pubstackBidAdapter: initial release Feb 20, 2026

Comments

Conversation

gpolaert commented Feb 18, 2026

Type of change

Description of change

Other information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

gpolaert commented Feb 18, 2026

Uh oh!

coveralls commented Feb 18, 2026

Pull Request Test Coverage Report for Build 22158457780

Details

💛 - Coveralls

Uh oh!

patmmccann Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

patmmccann left a comment

Choose a reason for hiding this comment

Uh oh!

patmmccann commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants