Conversation
gurodrigues
force-pushed
the
feat/adzep
branch
from
2ee40de to
0d58aac
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ee40decc5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| gulp build | ||
| gulp bundle --tag prebid-full --modules=modules-full.json | ||
| gulp bundle --tag prebid-no-user-sync --modules=modules-no-user-sync.json | ||
| gulp bundle --tag prebid-adzep --modules=modules-adzep.json |
There was a problem hiding this comment.
This step invokes gulp directly, but after npm ci the CLI is only guaranteed under node_modules/.bin; in a plain GitHub Actions run shell that path is not reliably on PATH, so the job can fail with gulp: command not found before any artifacts are built or uploaded. I checked this workflow and compared it with existing repo workflows, which call npx gulp ... for the same reason.
Useful? React with 👍 / 👎.
1 participant
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information