1plus x RTD Adapter: remove bidder specific handling enforcement#9952
1plus x RTD Adapter: remove bidder specific handling enforcement#9952patmmccann wants to merge 5 commits intoprebid-8from
Conversation
|
@bwhisp can you please check and approve the pull request here? Ideally we would like to support this bid adaptor but I understand that this is up to AppNexus to change their implementation.. we can address this, if any workaround available, on a next release |
bwhisp
left a comment
bwhisp
left a comment
There was a problem hiding this comment.
just a small cleanup if you agree with it
Co-authored-by: Anass Seddiki <anass.seddiki@1plusx.com>
|
Alternatively, we could trash this pr and you can make the bidders you do 155-164 for come from config instead of being hardcoded. I think airgrid is doing something similar as a model. |
| return bidderConfigCopy; | ||
| }; | ||
|
|
||
| const setAppnexusAudiences = (audiences) => { |
There was a problem hiding this comment.
removing this means that appnexus won't get audience data; I'm not sure that's the intent. Airgrid is replacing this with another kind of appnexus logic that's slightly more general, but they are not removing it entirely.
|
Hello @dgirardi I will attempt to replace the appnexus logic the same way Airgrid does it. Do you know the PR number where they do that ? |
|
Hello @patmmccann @dgirardi CC: @gggiakas |
|
closing in favor of #10001 |
This reverts commit 3959260.
* remove specific code to pubmatic * remove specific code to smartadserver bidder * update unit tests * remove rubicon specific code * refactor method * refactor this.#setBidderOrtb2 * fix lint issue * add ortb2 user.keywords on appnexs * try fix appnexus case * small refactor inspired on #9952 * try fix appnexus * Revert "try fix appnexus" This reverts commit db1fc08. * Revert "small refactor inspired on #9952" This reverts commit 3959260. * Revert "try fix appnexus case" This reverts commit 919540a. * Revert "add ortb2 user.keywords on appnexs" This reverts commit e2c5747.
…10005) * remove specific code to pubmatic * remove specific code to smartadserver bidder * update unit tests * remove rubicon specific code * refactor method * refactor this.#setBidderOrtb2 * fix lint issue * add ortb2 user.keywords on appnexs * try fix appnexus case * small refactor inspired on prebid#9952 * try fix appnexus * Revert "try fix appnexus" This reverts commit db1fc08. * Revert "small refactor inspired on prebid#9952" This reverts commit 3959260. * Revert "try fix appnexus case" This reverts commit 919540a. * Revert "add ortb2 user.keywords on appnexs" This reverts commit e2c5747.
4 participants
Partial fulfillment of #8596