Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code coverage summaryNote:
revxRefer here for heat map coverage report |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
|
Hi @bsardo could you please review this |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
|
@pm-jaydeep-mohite can you please review? |
adapters/revx/revx.go
Outdated
| if bid.MType == 0 { | ||
| return "", &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unsupported mtype %d for bid %s", bid.MType, bid.ID), | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need this extra check as default: case can handle this ?
There was a problem hiding this comment.
Hi, you're right — the default case covers it. We'll remove the extra check and update the review. Thanks!
Code coverage summaryNote:
revxRefer here for heat map coverage report |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
pm-jaydeep-mohite
left a comment
pm-jaydeep-mohite
left a comment
There was a problem hiding this comment.
Added few comments
Code coverage summaryNote:
revxRefer here for heat map coverage report |
|
Hi @pm-jaydeep-mohite could you please review the updated changes |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
|
@bsardo @ccorbo @pm-jaydeep-mohite |
| @@ -0,0 +1,94 @@ | |||
| { | |||
There was a problem hiding this comment.
issue: theres no difference between this file and invalid-mtype.json, can you please remove this
Code coverage summaryNote:
revxRefer here for heat map coverage report |
|
@ccorbo |
|
@asifrahiman https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html, instructions under |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
@ccorbo It seems to have been an issue with IDE. We have re added the file. Please assist with the review. |
|
@bsardo |
openrtb_ext/bidders.go
Outdated
| BidderZeroClickFraud, | ||
| BidderZetaGlobalSsp, | ||
| BidderZmaticoo, | ||
| BidderRevX, |
There was a problem hiding this comment.
Nitpick: please move this up in the list so the list is alphabetical.
static/bidder-info/revx.yaml
Outdated
|
|
||
| maintainer: | ||
| email: prebidsupport@revx.io | ||
|
|
static/bidder-info/revx.yaml
Outdated
| @@ -0,0 +1,17 @@ | |||
| endpoint: "https://prebid-use.atomex.net" | |||
|
|
|||
openrtb_ext/imp_revx.go
Outdated
| package openrtb_ext | ||
|
|
||
| type ExtImpRevX struct { | ||
| PubName string `json:"pubName"` // Publisher Name (used for dynamic URL building) |
There was a problem hiding this comment.
Is this JSON annotation supposed to be pubName or pubname?
There was a problem hiding this comment.
Not required as we removed this object
adapters/revx/params_test.go
Outdated
| } | ||
|
|
||
| var validParams = []string{ | ||
| `{"pubname": "publisher123"}`, |
There was a problem hiding this comment.
Please add the following test case to test the min length of 1:
{"pubname": "p"},
There was a problem hiding this comment.
Not required as we removed this param
adapters/revx/revx.go
Outdated
| if response.StatusCode == http.StatusBadRequest { | ||
| return nil, []error{&errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Received 400 Bad Request from endpoint: %s", a.endPoint), | ||
| }} | ||
| } |
There was a problem hiding this comment.
You can delete this. The call on line 71 to CheckResponseStatusCodeForErrors checks for a 400 status code.
| // Handle specific status codes first | ||
| if response.StatusCode == http.StatusNoContent { | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
Replace this with the adapter helper function:
if adapters.IsResponseStatusCodeNoContent(responseData) {
return nil, nil
}
adapters/revx/revx.go
Outdated
| bidResponse.Bids = typedBids | ||
| bidResponse.Currency = serverBidResponse.Cur | ||
|
|
||
| return bidResponse, nil |
There was a problem hiding this comment.
You should always return errs even if there is a typed bid: return bidResponse, errs
static/bidder-info/revx.yaml
Outdated
| @@ -0,0 +1,17 @@ | |||
| endpoint: "https://prebid-use.atomex.net" | |||
There was a problem hiding this comment.
This endpoint doesn't appear to be live:
curl -i --location --request POST https://prebid-use.atomex.net
HTTP/1.1 504 Gateway Time-out
Date: Fri, 09 Jan 2026 22:36:01 GMT
Content-Type: text/html
Content-Length: 173
Connection: keep-alive
<html>
<head><title>504 Gateway Time-out</title></head>
<body>
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>openresty/1.17.8.2</center>
</body>
</html>
There was a problem hiding this comment.
I'm getting the same thing, it looks like POST requests aren't working but GET requests are
There was a problem hiding this comment.
asifabdulrahiman@AFL-IN-LAP577 ~ % curl -i --location --request POST 'https://prebid-use.atomex.net?ag=PREBID'
HTTP/1.1 501 Not Implemented
Date: Tue, 27 Jan 2026 04:29:22 GMT
Content-Type: text/plain; charset=UTF-8
Content-Length: 0
Connection: keep-alive
asifabdulrahiman@AFL-IN-LAP577 ~ %
The endpoint is live and requires the ag parameter to function correctly. This has been updated in revx.yaml.
At present, the URL will return a 501 response until it is fully enabled on our backend, which is expected until we receive actual supply. Please note that the 501 response is being returned by our backend servers.
If live testing of the flow is required, we can set up an environment to support that.
|
@nikithacode please see my latest comments. This PR is close. |
|
Also, please open a docs PR at prebid.github.io and provide the link to it in this PR description above. |
|
@asifarahiman please see above. |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
|
@bsardo @ccorbo Thank you. |
|
@asifarahiman please review and provide changes for @bsardo 's outstanding comments |
Code coverage summaryNote:
revxRefer here for heat map coverage report |
6 participants
No description provided.