New Adapter: TRUSTX (remove Grid alias) by trustXops · Pull Request #4614 · prebid/prebid-server

trustXops · 2025-11-26T15:16:07Z

github-actions · 2025-11-26T15:17:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 6e452fe

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	87.5%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	96.2%

karwaankit32 · 2026-01-09T09:51:27Z

Please rebase this PR with the latest changes as that is causing the server to not be up due to a bug which has been fixed

github-actions · 2026-01-09T10:16:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2b6b83f

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	87.5%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	96.2%

trustXops · 2026-01-09T10:21:44Z

Hi @karwaankit32, rebased! Is there anything else I can do to expedite merging this PR?

karwaankit32 · 2026-01-09T10:23:06Z

Hi @karwaankit32, rebased! Is there anything else I can do to expedite merging this PR?

Thanks. I am in the process of reviewing the PR today and will post feedback by EOD. Thanks!

karwaankit32 · 2026-01-09T09:49:17Z

adapters/trustx/params_test.go

+}
+
+var validParams = []string{
+	`{}`,


Question: is a default Uid being 0 acceptable here? Is there a reason why we are not making Uid required?

Hi, 0 is acceptable, as publishers can also pass the value in other fields (e.g. imp.tagid)

karwaankit32 · 2026-01-09T09:50:32Z

adapters/trustx/params_test.go

+	`{"uid": 1234}`,
+	`{"uid": 1234, "keywords":{"site": {}, "user": {}}}`,
+}
+var invalidParams = []string{


Can we add other test cases where we also check data types of Uid and Keywords?
Ex: passing a "string" Uid and similarly for Keywords?

Added 2 test cases.

karwaankit32 · 2026-01-09T13:43:40Z

adapters/trustx/trustx.go

+func setImpExtData(imp *openrtb2.Imp) {
+	var ext impExt
+	if err := jsonutil.Unmarshal(imp.Ext, &ext); err != nil {
+		return


do we want to log these errors?

I don't think so, as the data read from the imp ext (adslot) is optional to us, and the request is valid without it.

Makes sense but i'd recommend adding a test case for this

Added a test case for this!

karwaankit32 · 2026-01-09T14:02:16Z

adapters/trustx/trustx.go

+		return nil
+	}
+	var bidMeta *openrtb_ext.ExtBidPrebidMeta
+	if be.Bidder.TrustX.NetworkName != "" {


Can there be a case where TrustX is empty? Won't this logic break in such cases?

Yes, there can be a case where we don't return the network name, but TrustX isn't a pointer so nothing will break, bid meta will just be nil.

github-actions · 2026-01-09T15:50:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 058ffe5

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	87.5%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	96.2%

github-actions · 2026-01-09T16:23:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5cc01b6

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	81.8%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:82:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:116:	setImpExtData	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:130:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:162:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:193:	getBidMeta	100.0%
total:									(statements)	97.5%

bsardo · 2026-01-09T19:29:04Z

static/bidder-info/trustx.yaml

  redirect:
-    url: "https://x.bidswitch.net/check_uuid/{{.RedirectURL}}?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}"
-    userMacro: "${BSW_UUID}"
-
+    url: "https://sync.trustx.org/usync-pbs?us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redirect={{.RedirectURL}}"
+    userMacro: "$UID"


Verified redirect works. The endpoint successfully redirects to the PBS setuid endpoint with the trustx uid which is then set in the PBS cookie by the setuid endpoint.

bsardo · 2026-01-09T19:37:20Z

static/bidder-info/trustx.yaml

+  iframe:
+    url: "https://static.cdn.trustx.org/x/user_sync.html?source=pbs&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redirect={{.RedirectURL}}"
+    userMacro: "$UID"


Iframe does not appear to be working. I see a 200 response from this endpoint with an html body which is triggering a request to https://sync.trustx.org/usync and that is redirecting to the PBS setuid endpoint assuming https but in this case it is http.

Is the redirect necessary? I believe I have seen other adapters embed the PBS host URL in the html response firing a request to the setuid endpoint directly from the client.

Hi, the failure is caused by browser mixed-content restrictions: an HTTPS iframe cannot initiate requests to an HTTP PBS setuid endpoint.
This would fail even without the redirect hop (calling the endpoint directly from the client).
For iframe sync to work reliably, the PBS endpoint must be served over HTTPS.

This is not adapter-specific behavior, but a native browser security restriction.
Reference: https://developer.mozilla.org/en-US/docs/Web/Security/Defenses/Mixed_content

Hi @bsardo , could you please take a look at my comment above?

bsardo

Looks good, just a couple of comments.

bsardo · 2026-01-30T15:11:21Z

static/bidder-info/trustx.yaml

@@ -1,9 +1,19 @@
-aliasOf: grid
+endpoint: "https://ads.trustx.org/pbs"


Verified endpoint is reachable

curl -i --location --request POST https://ads.trustx.org/pbs HTTP/2 204 access-control-allow-credentials: true access-control-allow-origin: * vary: Origin date: Fri, 30 Jan 2026 15:11:03 GMT

bsardo · 2026-01-30T15:13:08Z

static/bidder-info/trustx.yaml

 maintainer:
-  email: "grid-tech@themediagrid.com"
-gvlVendorID: 686
+  email: "prebid@trustx.org"


We've sent an email to this address. Please respond with a message of 'received' to confirm that it is reachable.

bsardo · 2026-01-30T16:24:05Z

adapters/trustx/trustx.go

+		extJSON, err := jsonutil.Marshal(ext)
+		if err == nil {
+			imp.Ext = extJSON
+		}


We are ok with swallowing the unmarshalling error above in this function but please do not swallow marshaling errors. We've seen instances in production where shared memory corruption results in a marshalling error causing an adapter panic that tips us off that there is a real problem.

Changed marshalling error handling

bsardo · 2026-01-30T16:33:47Z

adapters/trustx/trustxtest/supplemental/test-response.json

Is this test needed? It looks like your other tests already cover what it is covering.

Agreed, removed

github-actions · 2026-02-02T10:53:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 8d6c85b

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	71.4%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:86:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:120:	setImpExtData	90.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:137:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:169:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:200:	getBidMeta	100.0%
total:									(statements)	94.0%

github-actions · 2026-02-02T10:53:45Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 40489ca

trustx

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:50:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:57:	MakeRequests	71.4%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:86:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:120:	setImpExtData	90.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:137:	getHeaders	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:169:	getTypedBid	100.0%
github.com/prebid/prebid-server/v3/adapters/trustx/trustx.go:200:	getBidMeta	100.0%
total:									(statements)	94.0%

bsardo

Looks good. Once I receive a response to the email I sent to prebid@trustx.org I will approve.

trustXops mentioned this pull request Nov 26, 2025

Trustx bidder adapter prebid/prebid.github.io#6355

Merged

6 tasks

bsardo added the adapter label Dec 3, 2025

Submit trustx adapter

2b6b83f

trustXops force-pushed the trustx-bidder-adapter branch from 6e452fe to 2b6b83f Compare January 9, 2026 10:15

karwaankit32 reviewed Jan 9, 2026

View reviewed changes

additional test cases for parameters

058ffe5

add a test case for invalid imp ext

5cc01b6

karwaankit32 previously approved these changes Jan 9, 2026

View reviewed changes

bsardo reviewed Jan 9, 2026

View reviewed changes

bsardo assigned karwaankit32 and bsardo Jan 11, 2026

trustXops requested a review from bsardo January 13, 2026 16:50

bsardo reviewed Jan 30, 2026

View reviewed changes

resolve PR comments

8d6c85b

trustXops dismissed karwaankit32’s stale review via 8d6c85b February 2, 2026 10:52

Merge branch 'prebid:master' into trustx-bidder-adapter

40489ca

bsardo reviewed Feb 2, 2026

View reviewed changes

bsardo approved these changes Feb 3, 2026

View reviewed changes

karwaankit32 approved these changes Feb 3, 2026

View reviewed changes

bsardo merged commit 828b830 into prebid:master Feb 3, 2026
6 checks passed

cross-repo-issue-creation bot mentioned this pull request Feb 3, 2026

Port PR from PBS-Go: New Adapter: TRUSTX (remove Grid alias) prebid/prebid-server-java#4375

Open

mikael-lundin pushed a commit to Adnuntius/prebid-server that referenced this pull request Feb 5, 2026

New Adapter: TRUSTX (remove Grid alias) (prebid#4614)

04e6705

openads-sync-bot bot mentioned this pull request Feb 17, 2026

Upstream PR #4614: New Adapter: TRUSTX (remove Grid alias) (#4614) OpenAds-Auction/OpenAdsServer#100

Closed

		@@ -1,9 +1,19 @@
		aliasOf: grid
		endpoint: "https://ads.trustx.org/pbs"

Comments

Conversation

trustXops commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025

Code coverage summary

trustx

Uh oh!

karwaankit32 commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2026

Code coverage summary

trustx

Uh oh!

trustXops commented Jan 9, 2026

Uh oh!

karwaankit32 commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 9, 2026

Code coverage summary

trustx

Uh oh!

github-actions bot commented Jan 9, 2026

Code coverage summary

trustx

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bsardo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 2, 2026

Code coverage summary

trustx

Uh oh!

github-actions bot commented Feb 2, 2026

Code coverage summary

trustx

trustXops commented Nov 26, 2025 •

edited

Loading

karwaankit32 commented Jan 9, 2026 •

edited

Loading