RTBHouse: Extract tagid from Imp fields by pjaworski-rtbh · Pull Request #4624 · prebid/prebid-server

pjaworski-rtbh · 2025-12-03T13:08:31Z

🔧 Type of changes

bid adapter update
enhancement

✨ What's the context?

Related PR (Java): prebid/prebid-server-java#4306
RTBHouse bidder was not setting imp.tagid in outgoing requests, which could impact ad targeting effectiveness. This change adds support for populating tagid from various incoming request fields with a defined priority order.

📋 Description

Adds logic to set imp.tagid in RTBHouse bid requests using fallback priority: imp.ext.gpid → imp.ext.data.adserver.adslot → imp.ext.data.pbadslot → imp.id → null. This ensures better ad targeting by providing RTBHouse with appropriate tagid values.

🧪 Testing results

Tests run: 34, Failures: 0, Errors: 0, Skipped: 0
coverage: 92.6% of statements
All RTBHouse bidder tests pass successfully. Updates:

New exemplary tests for the feature (4 tests)
Updated existing 17 exemplary and 9 supplemental tests to include imp.tagid in expected outgoing requests

Other information

Please reach us at inventory_support@rtbhouse.com with piotr.jaworski@rtbhouse.com and cc leandro.otani@rtbhouse.com.

github-actions · 2025-12-03T13:09:21Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a29a2da

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		86.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:165:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:218:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:226:	getTagIDFromImpExt	91.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:255:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:291:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:358:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:369:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:389:	resolveMacros		100.0%
total:									(statements)		91.6%

…andling and simplify implementation

github-actions · 2025-12-03T13:33:39Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 94f705b

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:161:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:214:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:221:	getTagIDFromImpExt	91.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:250:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:286:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:353:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:364:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:384:	resolveMacros		100.0%
total:									(statements)		92.6%

pjaworski-rtbh · 2026-01-09T15:13:38Z

@bsardo Could you please share an estimate for when we can expect an updated status on this PR? The Java PR is nearly finalized, and we’d like to bring this one to the same point as well.

Taxel

Please make sure pbadslot is written in lowercase both in the comment and the test.
The code (and lowercased field name) seems to be correct.

adapters/rtbhouse/rtbhouse.go

adapters/rtbhouse/rtbhousetest/exemplary/tagid-precedence-gpid-over-pbadslot.json

adapters/rtbhouse/rtbhouse.go

github-actions · 2026-02-11T10:39:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9cc6942

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:161:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:214:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:221:	getTagIDFromImpExt	91.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:250:	getImpressionExt	80.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:279:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:346:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:357:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:377:	resolveMacros		100.0%
total:									(statements)		92.5%

linux019

Please use jsonutil wrapper instead of standard json - it much faster

adapters/rtbhouse/rtbhouse.go

github-actions · 2026-02-18T09:41:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, dbd3765

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:161:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:214:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:221:	getTagIDFromImpExt	91.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:248:	getImpressionExt	80.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:277:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:344:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:355:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:375:	resolveMacros		100.0%
total:									(statements)		92.5%

pjaworski-rtbh

@linux019 All suggestions have been covered.

adapters/rtbhouse/rtbhouse.go

github-actions · 2026-02-20T16:19:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b9ef063

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:161:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:214:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:221:	getTagIDFromImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:244:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:265:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:332:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:343:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:363:	resolveMacros		100.0%
total:									(statements)		93.5%

github-actions · 2026-02-20T16:33:19Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9d59dea

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:161:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:214:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:221:	getTagIDFromImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:244:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:265:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:332:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:343:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:363:	resolveMacros		100.0%
total:									(statements)		93.5%

pjaworski-rtbh added 2 commits December 1, 2025 17:26

RTBHouse: Enhance TagID handling and add new test cases

58dcfd1

RTBHouse: Add TagID extraction from adserver.adslot and new test case

a29a2da

pjaworski-rtbh marked this pull request as ready for review December 3, 2025 13:21

pjaworski-rtbh mentioned this pull request Dec 3, 2025

RTBHouse: Extract tagid from Imp fields prebid/prebid-server-java#4306

Merged

2 tasks

RTBHouse: refactor clearAuctionEnvironment function to remove error h…

94f705b

…andling and simplify implementation

bsardo added the adapter label Dec 3, 2025

bsardo assigned pm-jaydeep-mohite and bsardo Jan 12, 2026

bsardo assigned Taxel and linux019 and unassigned pm-jaydeep-mohite and bsardo Feb 3, 2026

Taxel requested changes Feb 11, 2026

View reviewed changes

adapters/rtbhouse/rtbhouse.go Outdated Show resolved Hide resolved

adapters/rtbhouse/rtbhousetest/exemplary/tagid-precedence-gpid-over-pbadslot.json Outdated Show resolved Hide resolved

adapters/rtbhouse/rtbhouse.go Outdated Show resolved Hide resolved

RTBHouse: fixed correct casing in the adapter code and test cases

9cc6942

Taxel previously approved these changes Feb 11, 2026

View reviewed changes

linux019 requested changes Feb 17, 2026

View reviewed changes

RTBHouse: use jsonutil for unmarshalling; improve error messaging

dbd3765

pjaworski-rtbh dismissed Taxel’s stale review via dbd3765 February 18, 2026 09:40

pjaworski-rtbh commented Feb 18, 2026

View reviewed changes

pjaworski-rtbh requested review from Taxel and linux019 February 18, 2026 09:44

Taxel requested changes Feb 19, 2026

View reviewed changes

adapters/rtbhouse/rtbhouse.go Outdated Show resolved Hide resolved

adapters/rtbhouse/rtbhouse.go Show resolved Hide resolved

adapters/rtbhouse/rtbhouse.go Outdated Show resolved Hide resolved

RTBHouse: simplify un/marshalling steps

b9ef063

RTBHouse: json -> jsonutil usage

9d59dea

pjaworski-rtbh requested a review from Taxel February 20, 2026 16:35

linux019 approved these changes Feb 21, 2026

View reviewed changes

Comments

Conversation

pjaworski-rtbh commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

📋 Description

🧪 Testing results

Other information

Uh oh!

github-actions bot commented Dec 3, 2025

Code coverage summary

rtbhouse

Uh oh!

github-actions bot commented Dec 3, 2025

Code coverage summary

rtbhouse

Uh oh!

pjaworski-rtbh commented Jan 9, 2026

Uh oh!

Taxel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Code coverage summary

rtbhouse

Uh oh!

linux019 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Code coverage summary

rtbhouse

Uh oh!

pjaworski-rtbh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Code coverage summary

rtbhouse

Uh oh!

github-actions bot commented Feb 20, 2026

Code coverage summary

rtbhouse

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pjaworski-rtbh commented Dec 3, 2025 •

edited

Loading