Skip to content

Comments

Adnuntius: Send EIDs in URL instead of body#4632

Open
mikael-lundin wants to merge 33 commits intoprebid:masterfrom
Adnuntius:eids-update
Open

Adnuntius: Send EIDs in URL instead of body#4632
mikael-lundin wants to merge 33 commits intoprebid:masterfrom
Adnuntius:eids-update

Conversation

@mikael-lundin
Copy link
Contributor

We ave added the option to read all eids so this change reflects that. Moved from being sent in the body to being sent as a url parameter.

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5c544c8

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:26:		Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:36:		MakeRequests			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:40:		generateRequests		92.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:165:		MakeBids			90.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:191:		generateBidResponse		93.6%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:282:		generateAdResponse		78.3%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:19:	setHeaders			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:35:	makeEndpointUrl			91.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:102:	getImpSizes			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:123:	getSiteExtAsKv			80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:133:	getGDPR				92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:158:	generateReturnExt		86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:193:	generateAdUnit			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:227:	convertMarkupTypeToBidType	75.0%
total:										(statements)			91.5%

@bsardo bsardo added the adapter label Jan 6, 2026
@bsardo bsardo changed the title Adnuntius Bid Adapter: Moved EIDs to be sent over URL instead of in the body Adnuntius: Send EIDs in URL instead of body Jan 12, 2026
@bsardo bsardo assigned bsardo, linux019 and ccorbo and unassigned bsardo Jan 12, 2026
ccorbo
ccorbo previously approved these changes Jan 13, 2026
@bsardo
Copy link
Collaborator

bsardo commented Feb 3, 2026

@mikael-lundin please see recent comments above.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d7c018b

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:26:		Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:36:		MakeRequests			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:40:		generateRequests		92.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:165:		MakeBids			90.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:191:		generateBidResponse		93.6%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:282:		generateAdResponse		78.3%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:19:	setHeaders			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:35:	makeEndpointUrl			91.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:102:	getImpSizes			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:123:	getSiteExtAsKv			80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:133:	getGDPR				92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:158:	generateReturnExt		86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:193:	generateAdUnit			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:227:	convertMarkupTypeToBidType	75.0%
total:										(statements)			91.5%

@mikael-lundin
Copy link
Contributor Author

mikael-lundin commented Feb 5, 2026

Sorry for being slow, should be changed now.

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 47912a5

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:26:		Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:36:		MakeRequests			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:40:		generateRequests		92.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:165:		MakeBids			90.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:191:		generateBidResponse		93.6%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:282:		generateAdResponse		78.3%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:19:	setHeaders			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:35:	makeEndpointUrl			91.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:102:	getImpSizes			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:123:	getSiteExtAsKv			80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:133:	getGDPR				92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:158:	generateReturnExt		86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:193:	generateAdUnit			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:227:	convertMarkupTypeToBidType	75.0%
total:										(statements)			91.5%

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 5036ccf

adnuntius

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:26:		Builder				100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:36:		MakeRequests			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:40:		generateRequests		92.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:165:		MakeBids			90.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:191:		generateBidResponse		93.6%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius.go:282:		generateAdResponse		78.3%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:19:	setHeaders			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:35:	makeEndpointUrl			92.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:109:	getImpSizes			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:130:	getSiteExtAsKv			80.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:140:	getGDPR				92.9%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:165:	generateReturnExt		86.7%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:200:	generateAdUnit			100.0%
github.com/prebid/prebid-server/v3/adapters/adnuntius/adnuntius_utils.go:234:	convertMarkupTypeToBidType	75.0%
total:										(statements)			91.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.