Fix script injection vulnerability in cross-repo-issue workflow#4656
Open
jun06t wants to merge 1 commit intoprebid:masterfrom
Open
Fix script injection vulnerability in cross-repo-issue workflow#4656jun06t wants to merge 1 commit intoprebid:masterfrom
jun06t wants to merge 1 commit intoprebid:masterfrom
Conversation
The workflow was vulnerable to script injection because `github.event.pull_request.title` was directly interpolated into the shell command. An attacker could craft a malicious PR title to execute arbitrary commands and potentially exfiltrate the GITHUB_TOKEN. This fix passes user-controlled inputs via environment variables instead of direct interpolation, which prevents shell injection. Reference: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#understanding-the-risk-of-script-injections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/cross-repo-issue.ymlPR_TITLE,PR_NUMBER,PR_MERGED_AT) via environment variables instead of direct interpolationGITHUB_TOKENthrough malicious PR titlesBackground
The workflow was vulnerable to script injection because
github.event.pull_request.titlewas directly interpolated into the shell command. An attacker could craft a malicious PR title like:This would execute arbitrary commands and potentially exfiltrate the GitHub App token.
Fix
Changed from direct interpolation:
To environment variable approach:
Reference
Test Plan