New adapter: BeOp by jeans11 · Pull Request #4660 · prebid/prebid-server

jeans11 · 2026-01-14T09:57:25Z

Type of change

Documention PR: prebid/prebid.github.io#6432

BeOp adapter

github-actions · 2026-01-14T09:57:43Z

adapters/beop/beop.go

+			continue
+		}
+		bidResponseFinal.Bids = append(bidResponseFinal.Bids, &adapters.TypedBid{
+			Bid:     &bid,


Found incorrect assignment made to Bid. bid variable receives a new value in each iteration of range loop. Assigning the address of bid (&bid) to Bid will result in a pointer that always points to the same memory address with the value of the last iteration. This can lead to unexpected behavior or incorrect results. Refer https://go.dev/play/p/9ZS1f-5h4qS
Consider using an index variable in the seatBids.Bid loop as shown below

for _, seatBid := range response.SeatBid { for i := range seatBids.Bid { ... responseBid := &adapters.TypedBid{ Bid: &seatBids.Bid[i], ... } ... ... } }

Please take a look at this comment

github-actions · 2026-01-14T09:57:44Z

adapters/beop/beop.go

+		var bidExt openrtb_ext.ExtBid
+		err := jsonutil.Unmarshal(bid.Ext, &bidExt)
+		if err == nil && bidExt.Prebid != nil {
+			return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))


Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

github-actions · 2026-01-14T09:58:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d49baa1

beop

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/beop/beop.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:33:	getRequestExtImpBeop	66.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:54:	buildEndpointURL	91.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:75:	MakeRequests		81.2%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:113:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:127:	MakeBids		86.4%
total:								(statements)		83.6%

github-actions · 2026-01-22T10:05:10Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 49abbe9

beop

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/beop/beop.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:33:	getRequestExtImpBeop	66.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:54:	buildEndpointURL	91.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:75:	MakeRequests		81.2%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:113:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:131:	MakeBids		87.0%
total:								(statements)		81.7%

sebrobert · 2026-01-27T10:47:41Z

Hello @bsardo, hope you are good 🙏
Can we have an update on that PR and have an approximative date of availability for our customers that are expecting it ?
In advance, thanks
Best

karwaankit32 · 2026-01-29T06:01:18Z

Can you please create a documentation PR and link it in the description?

static/bidder-info/beop.yaml

karwaankit32 · 2026-01-29T10:45:33Z

static/bidder-params/beop.json

@@ -0,0 +1,33 @@
+{


I do not see tests related to the bidder params. Can you please add that under beop adapters folder with file name params_test.go?

Did you want a test with missing param for example?

Hi, what i meant was adding tests for valid and invalid params in a dedicated file adapters/beop/params_test.go

Please take a look at example - https://github.com/prebid/prebid-server/blob/master/adapters/adverxo/params_test.go

Oh! Sorry for the misunderstanfing: ae27191

karwaankit32 · 2026-02-10T07:04:05Z

adapters/beop/beop.go

+			Message: "ext.bidder not provided",
+		}
+	}
+	if beopExt.BeopPublisherID == "" && beopExt.BeopNetworkID == "" {


Not sure if we need this validation since if the param validation fails, it the adapter will never be called. In the bidder params configuration, we have already provided that either pid or nid, ntpnid needs to be provided

Oh I didn't know that, so yeah we don't need extra validation.

karwaankit32 · 2026-02-10T07:13:29Z

adapters/beop/beop.go

+			continue
+		}
+		bidResponseFinal.Bids = append(bidResponseFinal.Bids, &adapters.TypedBid{
+			Bid:     &bid,


Please take a look at this comment

karwaankit32 · 2026-02-10T07:15:40Z

adapters/beop/beop.go

+		}
+	}
+	var beopExt openrtb_ext.ExtImpBeop
+	if err := jsonutil.Unmarshal(bidderExt.Bidder, &beopExt); err != nil {


I think we can add coverage for unmarshalling errors in this code path

karwaankit32 · 2026-02-10T07:16:47Z

adapters/beop/beop.go

+	url, err := url.Parse(a.endpoint)
+	if err != nil {
+		return "", &errortypes.Warning{
+			Message: "Failed to parse endpoint",


Do we need to do this validation since endpoint is supplanted from the config by Prebid ?

karwaankit32 · 2026-02-10T07:17:48Z

adapters/beop/beop.go

+	case openrtb2.MarkupVideo:
+		bidType = openrtb_ext.BidTypeVideo
+	case openrtb2.MarkupAudio:
+		bidType = openrtb_ext.BidTypeAudio


Please add coverage for BidType - Audio, MarkupNative and invalid type

Since the beop.yaml allow only banner and video I will remove the extra cases.

adapters/beop/beop.go

github-actions · 2026-02-13T14:53:21Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7908799

beop

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/beop/beop.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:33:	getRequestExtImpBeop	66.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:54:	buildEndpointURL	91.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:75:	MakeRequests		81.2%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:113:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:131:	MakeBids		87.0%
total:								(statements)		81.7%

sebrobert · 2026-02-13T16:33:17Z

Please find here the DOC PR : prebid/prebid.github.io#6432

github-actions · 2026-02-13T17:07:02Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a5cb34d

beop

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/beop/beop.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:33:	getRequestExtImpBeop	85.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:49:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:65:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:103:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:117:	MakeBids		96.0%
total:								(statements)		94.0%

karwaankit32 · 2026-02-16T05:42:28Z

adapters/beop/beop.go

+	responseData *adapters.ResponseData) (
+	*adapters.BidderResponse, []error,
+) {
+	if responseData.StatusCode == http.StatusNoContent {


Missing test case

karwaankit32 · 2026-02-17T03:31:14Z

static/bidder-info/beop.yaml

+endpoint: "https://hb.collectiveaudience.co/rtb/bid"
+endpointCompression: gzip
+maintainer:
+  email: tech@collectiveaudience.co


Sent a verification mail on this mailbox. Please acknowledge over the mailbox with "received"

Thanks

github-actions · 2026-02-18T09:43:51Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 963f154

beop

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/beop/beop.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:33:	getRequestExtImpBeop	85.7%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:49:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:65:	MakeRequests		87.5%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:103:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/beop/beop.go:117:	MakeBids		100.0%
total:								(statements)		95.5%

karwaankit32

Acknowledging that i received a reply over the mailbox

jeans11 added 7 commits December 11, 2025 11:04

feat: add beop.json bidder params

0c56b14

feat: add beop.yaml bidder info

3b044f2

feat: add imp_beop.go

db6bc4e

feat: add beop.go adapter

b0b4833

feat: register beop adapter

70e7896

feat: add beop adapter test

68f08c5

Merge pull request #1 from BeOpinion/adapter

d49baa1

BeOp adapter

github-actions bot reviewed Jan 14, 2026

View reviewed changes

bsardo added the adapter label Jan 20, 2026

jeans11 added 3 commits January 22, 2026 11:02

refacto: update bid reference

64e60bf

refacto: use mtype field

77c9c14

refacto: tests

49abbe9

bsardo assigned bsardo and danylo-kazymyrov-teqblaze Jan 28, 2026

karwaankit32 reviewed Jan 29, 2026

View reviewed changes

static/bidder-info/beop.yaml Show resolved Hide resolved

bsardo mentioned this pull request Feb 3, 2026

New Adapter: BeOp (WIP) #4566

Closed

karwaankit32 reviewed Feb 10, 2026

View reviewed changes

Merge branch 'prebid:master' into master

7908799

jeans11 added 3 commits February 13, 2026 16:15

review: remove extra cases

d8f8a75

review: remove extra validation

acb9c44

review: remove url parse error check

d8643a6

sebrobert mentioned this pull request Feb 13, 2026

BeOp Adapter : Add Prebid Server in Doc prebid/prebid.github.io#6432

Open

2 tasks

review: add missing bidder params test

42bba13

review: add invalid bid type test

a5cb34d

karwaankit32 reviewed Feb 16, 2026

View reviewed changes

karwaankit32 reviewed Feb 17, 2026

View reviewed changes

jeans11 added 2 commits February 18, 2026 10:42

review: add params_test

ae27191

review: add status code no content test

963f154

karwaankit32 approved these changes Feb 19, 2026

View reviewed changes

Comments

Conversation

jeans11 commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 14, 2026

Code coverage summary

beop

Uh oh!

github-actions bot commented Jan 22, 2026

Code coverage summary

beop

Uh oh!

sebrobert commented Jan 27, 2026

Uh oh!

karwaankit32 commented Jan 29, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026

Code coverage summary

beop

Uh oh!

sebrobert commented Feb 13, 2026

Uh oh!

github-actions bot commented Feb 13, 2026

Code coverage summary

beop

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 18, 2026

Code coverage summary

beop

Uh oh!

karwaankit32 left a comment

Choose a reason for hiding this comment

jeans11 commented Jan 14, 2026 •

edited

Loading