Modules: Validate execution plans at startup to remove per-request warnings

[postindustria-code]

Issue

Addresses Issue #3748

Behavior Changes

Before:

• Warning logged on every request for disabled modules: "Not found hook while building hook execution plan: "
• Created massive log noise in high-traffic environments

After:

• Warning logged once at startup for disabled modules with detailed context
• Zero warnings during request processing - clean logs
• Operators can easily toggle modules via enabled flag without modifying execution plans

✅ All existing tests pass - No breaking changes
✅ All new tests pass - New functionality verified
✅ Code formatting correct - Passes gofmt -s
✅ No vet issues - Passes go vet
✅ Project builds successfully - Compiles without errors
✅ Handles edge cases - Empty plans, nil repos, missing hooks

[antoxas1986]

Code Review - Minor Suggestions

Great PR! The implementation successfully addresses the log noise issue. Here are some minor suggestions to improve code clarity:

1. Variable Shadowing in router/router.go

File: router/router.go (lines 218-221)

Current code:

if errs = hooks.ValidateExecutionPlan(cfg.Hooks, repo); len(errs) > 0 {
    for _, err = range errs {
        logger.Warnf("%s", err.Error())
    }
}

Suggested:

if validationErrs := hooks.ValidateExecutionPlan(cfg.Hooks, repo); len(validationErrs) > 0 {
    for _, validationErr := range validationErrs {
        logger.Warnf("%v", validationErr)
    }
}

Rationale:

• Avoids shadowing the outer err variable
• Simplifies string formatting (%v instead of %s with .Error())

---

2. Add Clarifying Comment in hooks/plan.go

File: hooks/plan.go (around line 209, before the loop)

Suggested addition:

// Hook lookup and assembly. Hooks not found in repository are silently skipped
// as they are reported at startup via ValidateExecutionPlan().
for _, hookCfg := range cfg.HookSequence {
    if h, ok := getHookFn(hookCfg.ModuleCode); ok {
        group.Hooks = append(group.Hooks, HookWrapper[T]{
            Module: hookCfg.ModuleCode,
            Hook:   h,
        })
    }
}

Rationale: Makes it clear why hooks are silently skipped (they're already validated at startup), which helps future maintainers understand the design decision.

---

Summary

These are non-blocking suggestions that improve code clarity. The PR is ready to merge as-is if you prefer to keep the current implementation.

Overall: LGTM ✓

[postindustria-code]

@antoxas1986 Thanks for the review! I’ve fixed the minor nits. Need a re-approve.

[antoxas1986]

Thanks