Insticator: Support 2.6 OpenRTB fields and add app traffic endpoint#4668
Open
shubhamc-ins wants to merge 2 commits intoprebid:masterfrom
Open
Insticator: Support 2.6 OpenRTB fields and add app traffic endpoint#4668shubhamc-ins wants to merge 2 commits intoprebid:masterfrom
shubhamc-ins wants to merge 2 commits intoprebid:masterfrom
Conversation
Contributor
shubhamc-ins
commented
Jan 23, 2026
shubhamc-ins
commented
- Updated JSON test cases for Insticator adapter to improve formatting and structure.
- Added missing fields and corrected existing ones in the supplemental test files.
- Enhanced error handling in test cases for better clarity on expected outcomes.
- Updated bidder info YAML to include new endpoint and compression settings.
- Adjusted bidder parameters schema for clarity and consistency.
- Updated JSON test cases for Insticator adapter to improve formatting and structure. - Added missing fields and corrected existing ones in the supplemental test files. - Enhanced error handling in test cases for better clarity on expected outcomes. - Updated bidder info YAML to include new endpoint and compression settings. - Adjusted bidder parameters schema for clarity and consistency.
Code coverage summaryNote:
insticatorRefer here for heat map coverage report |
bsardo
changed the title
| @@ -1,7 +1,11 @@ | |||
| endpoint: "https://ex.ingage.tech/v1/prebidserver" | |||
| extra_info: '{"app_endpoint":"https://aex.ingage.tech/v1/prebidserver"}' | |||
There was a problem hiding this comment.
domain works but it responds with 403 (same is true for https://ex.ingage.tech/v1/prebidserver)
curl -i --location --request POST https://aex.ingage.tech/v1/prebidserver
HTTP/2 403
date: Mon, 02 Feb 2026 14:55:10 GMT
content-type: application/json
content-length: 13
server: cloudflare
cf-ray: 9c7a872aa845e77f-WAW
{
"nbr" : 2
}
There was a problem hiding this comment.
test request receives 403 error from the bidder, which is ok
{"id":"insticator-test-1","ext":{"debug":{"httpcalls":{"insticator":[{"uri":"https://ex.ingage.tech/v1/prebidserver?publisherId=test-publisher-id","requestbody":"{\"id\":\"insticator-test-1\",\"imp\":[{\"id\":\"imp-1\",\"banner\":{\"format\":[{\"w\":728,\"h\":90}]},\"secure\":1,\"ext\":{\"insticator\":{\"adUnitId\":\"fake-site-id\",\"publisherId\":\"test-publisher-id\"}}}],\"site\":{\"domain\":\"example.com\",\"page\":\"https://example.com/article-1\",\"publisher\":{\"id\":\"test-publisher-id\",\"domain\":\"example.com\"},\"ext\":{\"amp\":0}},\"device\":{\"ua\":\" Mozilla/5.0 (Linux; Android 13; Pixel 7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.6167.140 Mobile Safari/537.36\",\"ip\":\"192.0.2.1\"},\"test\":1,\"at\":1,\"source\":{\"tid\":\"cc92bdee-04fa-4369-95c1-c5d71cc737ba\"},\"ext\":{\"insticator\":{\"caller\":[{\"name\":\"Prebid-Server\",\"version\":\"n/a\"}]}}}","requestheaders":{"Accept":["application/json"],"Content-Encoding":["gzip"],"Content-Type":["application/json;charset=utf-8"],"Ip":["192.0.2.1"],"User-Agent":[" Mozilla/5.0 (Linux; Android 13; Pixel 7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.6167.140 Mobile Safari/537.36"],"X-Forwarded-For":["192.0.2.1"],"X-Prebid":["pbs-go/unknown"]},"responsebody":"","status":0}]},"resolvedrequest":{"id":"insticator-test-1","imp":[{"id":"imp-1","banner":{"format":[{"w":728,"h":90}]},"secure":1,"ext":{"prebid":{"bidder":{"insticator":{"adUnitId":"fake-site-id","publisherId":"test-publisher-id"}}},"tid":"cff946ad-8bff-473a-91af-1685f49942cb"}}],"site":{"domain":"example.com","page":"https://example.com/article-1","publisher":{"domain":"example.com"},"ext":{"amp":0}},"device":{"ua":" Mozilla/5.0 (Linux; Android 13; Pixel 7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.6167.140 Mobile Safari/537.36","ip":"192.0.2.1"},"test":1,"at":1,"source":{"tid":"cc92bdee-04fa-4369-95c1-c5d71cc737ba"},"ext":{"prebid":{"server":{"externalurl":"http://localhost:8000","gvlid":0,"datacenter":""}}}}},"errors":{"insticator":[{"code":4,"message":"Server responded with failure status: 403. Set request.test = 1 for debugging info."}]},"responsetimemillis":{"insticator":60},"prebid":{"auctiontimestamp":1770043887174}}}| } | ||
|
|
||
| // buildEndpointURL builds the endpoint URL with publisherId query parameter | ||
| func (a *adapter) buildEndpointURL(publisherId string, request *openrtb2.BidRequest) string { |
There was a problem hiding this comment.
confirmed, this function works
adapter sends request to Insticator PBS domain for inapp traffic
danylo-kazymyrov-teqblaze
left a comment
danylo-kazymyrov-teqblaze
left a comment
There was a problem hiding this comment.
Verified, Insticator adapter works with added changes
- Request to base domain returns 403
- Request from in app traffic goes to new domain from adapter
extra_infosection
| "httpCalls": [ | ||
| { | ||
| "expectedRequest": { | ||
| "uri": "https://insticator.example.com/v1/pbs?publisherId=test-publisher-id", |
There was a problem hiding this comment.
@shubhamc-ins
Since PR introduces new logic to send requests from app traffic to aex.ingage.tech I think you should update insticator_test.go and add extra_info#app_endpoint config, so JSON tests will use different domain for app and web traffic
Contributor
Author
There was a problem hiding this comment.
@danylo-kazymyrov-teqblaze Thanks for reviewing, I have added the test cases for app endpoint.
There was a problem hiding this comment.
@shubhamc-ins thank you! Nothing else from my side, approved
Code coverage summaryNote:
insticatorRefer here for heat map coverage report |
danylo-kazymyrov-teqblaze
approved these changes
Feb 3, 2026
przemkaczmarek
approved these changes
Feb 4, 2026
Contributor
Author
|
@przemkaczmarek @bsardo Thanks for reviewing. Please let me know if there is anything else required to get this merged in this week's Release. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.