Open
Conversation
This module provides comprehensive VAST processing for CTV ads: - vast.go: Main orchestration and BuildVastFromBidResponse entrypoint - handler.go: HTTP handler for VAST requests - types.go: Type definitions, interfaces (BidSelector, Enricher, Formatter) - config.go: PBS-style layered configuration (host/account/profile merge) - model/: VAST XML structures, parser, and helper functions - select/: Bid selection logic with SINGLE/TOP_N strategies - enrich/: VAST enrichment with VAST_WINS collision policy - format/: VAST XML formatting for GAM_SSU receiver Features: - Bid selection by price with deal prioritization - VAST XML parsing and skeleton generation - Metadata enrichment (pricing, advertiser, categories, debug) - Pod support with sequence numbering - Golden file tests for XML output
bsardo
changed the title
…Builder pattern - Rename vast.go to pipeline.go for clarity - Add module.go with Builder() and HandleRawBidderResponseHook() - Add module_test.go with comprehensive tests - Update README.md and README_EN.md with new structure - Fix import paths for new module location - Module now follows ortb2blocking/rulesengine patterns
…v_vast_enrichment)
- Change package name from 'vast' to 'ctv_vast_enrichment' - Register module in modules/builder.go - Fix ChangeSet mutation logic to use UpdateBids pattern - Add 'vast' import alias in subpackages (enrich, select, format) - Update tests to apply ChangeSet mutations before assertions
…\n\n- Add module registration section (modules/builder.go)\n- Replace YAML enabled_modules with proper host_execution_plan JSON config\n- Document ChangeSet/UpdateBids mutation pattern\n- Document clearInnerXML() XML serialization fix\n- Add package naming note (ctv_vast_enrichment + vast alias)\n- Add step-by-step PBS integration instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module provides comprehensive VAST processing for CTV ads:
module.go: PBS module entry point (Builder + HandleRawBidderResponseHook)
pipeline.go: Main orchestration and BuildVastFromBidResponse entrypoint
handler.go: HTTP handler for VAST requests
types.go: Type definitions, interfaces (BidSelector, Enricher, Formatter)
config.go: PBS-style layered configuration (host/account/profile merge)
model/: VAST XML structures, parser, and helper functions
select/: Bid selection logic with SINGLE/TOP_N strategies
enrich/: VAST enrichment with VAST_WINS collision policy
format/: VAST XML formatting for GAM_SSU receiver
Features:
Bid selection by price with deal prioritization
VAST XML parsing and skeleton generation
Metadata enrichment (pricing, advertiser, categories, debug)
Pod support with sequence numbering
VAST_WINS policy — preserves existing VAST values, does not overwrite
ChangeSet/UpdateBids mutation pattern (PBS-compliant, same as ortb2blocking)
clearInnerXML() fix preventing duplicate XML elements during serialization
Golden file tests for XML output