Skip to content

Comments

Intertech: Remove Adapter#4680

Open
bsardo wants to merge 1 commit intoprebid:masterfrom
bsardo:issue-3861-remove-intertech
Open

Intertech: Remove Adapter#4680
bsardo wants to merge 1 commit intoprebid:masterfrom
bsardo:issue-3861-remove-intertech

Conversation

@bsardo
Copy link
Collaborator

@bsardo bsardo commented Feb 9, 2026

Removing as specified in #3861.

@ChrisHuie
Copy link
Contributor

AGENT TESTING

PR #4680 Review: Intertech: Remove Adapter

Author: bsardo | Type: Bidder Removal | CI: Clean (all 6 checks passed)

Linked Issue: #3861 — Prebid Server 4.0


Triage Manifest

Field Value
PR Type bidder-removal
Files 22 files (19 removed, 3 modified)
Bidder intertech
Skills activated bidder-info-pr-review, bidder-params-pr-review, adapter-code-pr-review
CI Status Clean (validate 1.23.x, validate 1.24.x, validate-merge, run-coverage, notify, semgrep-check)
Aliases affected None (no bidders alias intertech)

Issue Context

This removal is tracked in issue #3861 (Prebid Server 4.0), which explicitly lists "remove intertech adapter" as a planned breaking change. The issue is the central tracking issue for all PBS 4.0 work, authored by bretg (PBS maintainer). The removal is intentional and planned.


Removal Completeness Check

Component File Status
Adapter code adapters/intertech/intertech.go Removed
Test runner adapters/intertech/intertech_test.go Removed
Params test adapters/intertech/params_test.go Removed
Exemplary fixtures (3) intertechtest/exemplary/simple-banner.json, simple-banner-muli-format.json, simple-native.json Removed
Supplemental fixtures (8) intertechtest/supplemental/ (bad_media_type, bad_response, invalid-banner-size, invalid-bidder, invalid-ext, no-cur-req, no-device, no-site-req, status-204, status-not-200) Removed
Imp extension struct openrtb_ext/imp_intertech.go Removed
Bidder info YAML static/bidder-info/intertech.yaml Removed
Params schema JSON static/bidder-params/intertech.json Removed
Builder registration exchange/adapter_builders.go Import + map entry removed
Bidder constant openrtb_ext/bidders.go BidderIntertech constant + coreBidderNames entry removed
Deprecation warning exchange/adapter_util.go Warning message added

Verdict: Complete. All adapter artifacts have been removed and a deprecation warning has been added for users still referencing intertech in their configuration.


Verification Details

Deprecation Warning

Check Result Evidence
Warning message added PASS "intertech": Bidder "intertech" is no longer available in Prebid Server. Please update your configuration.
Follows established pattern PASS Matches format of bizzclick, liftoff, gothamads entries in same map
Placement in code PASS Added to GetDisabledBidderWarningMessages in exchange/adapter_util.go

Registration Cleanup

Check Result Evidence
Import removed from adapter_builders.go PASS adapters/intertech import line removed
Builder map entry removed PASS openrtb_ext.BidderIntertech: intertech.Builder removed
Constant removed from bidders.go PASS BidderIntertech BidderName = "intertech" removed
coreBidderNames entry removed PASS BidderIntertech removed from the list
Alphabetical order preserved PASS Surrounding entries remain correctly ordered

Alias Impact

Check Result Evidence
No aliases depend on intertech PASS GitHub code search for aliasOf + intertech returns 0 results

Cross-Skill Concerns

Check Result Evidence
Issue linkage PASS PR description references #3861, which explicitly lists this removal
Intentionality PASS PBS 4.0 planned breaking change, authored by core team member
No orphaned references PASS All intertech-related files removed from all 3 skill domains

Recommendation: Approve

This is a clean, thorough bidder removal PR. All adapter artifacts (code, tests, test data, config, schema, registration) have been removed and a proper deprecation warning has been added. The removal is tracked in the PBS 4.0 issue (#3861), authored by a core team member, with no aliases affected. CI passes cleanly across all 6 checks.


Task Completion Summary

Task # Subject Status
18 PR Triage: Classify PR #4680, route files, check CI Completed
19 Verify intertech removal completeness Completed
20 Verify issue #3861 linkage and context Completed
21 Produce final review summary for PR #4680 Completed

Skills Called

Skill Outcome
pr-triage Executed inline — file categorization, CI check, PR type detection, cross-skill concerns
bidder-info-pr-review Executed inline — verified YAML removal
bidder-params-pr-review Executed inline — verified schema + imp struct removal
adapter-code-pr-review Executed inline — verified code, tests, test data, registration removal

Code / Commands Executed

Command Purpose Result
curl api.github.com/search/code?q=aliasOf+intertech Check for aliases depending on intertech 0 results (no aliases)

WebFetch API Calls

URL Purpose
api.github.com/.../pulls/4680 PR metadata
api.github.com/.../pulls/4680/files File list + patches (fetched twice for detail)
api.github.com/.../pulls/4680/commits Head SHA for CI check
api.github.com/.../commits/{sha}/check-runs CI status (all 6 passed)
api.github.com/.../pulls/4680/comments Existing review comments (none)
api.github.com/.../issues/4680/comments Existing PR comments (none)
api.github.com/.../issues/3861 Linked issue context (PBS 4.0 tracking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants