Skip to content

Cnvr adapter: pass prebids version number through for better tracking #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnwier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cnvr adapter: pass prebids version number through for better tracking #4688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion adapters/conversant/conversant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package conversant
import (
"encoding/json"
"fmt"
"github.com/prebid/prebid-server/v3/version"
"net/http"
"strings"

Expand Down Expand Up @@ -84,7 +85,10 @@ func (c *ConversantAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *

func parseCnvrParams(imp *openrtb2.Imp, cnvrExt openrtb_ext.ExtImpConversant, reqInfo *adapters.ExtraRequestInfo) []error {
imp.DisplayManager = "prebid-s2s"
imp.DisplayManagerVer = "2.0.0"

if version.Ver != "" {
imp.DisplayManagerVer = version.Ver
}

if imp.BidFloor <= 0 && cnvrExt.BidFloor > 0 {
imp.BidFloor = cnvrExt.BidFloor
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/exemplary/banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"secure": 1,
"bidfloor": 0.01,
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"banner": {
"format": [{"w": 300, "h": 250}]
},
Expand Down
3 changes: 1 addition & 2 deletions adapters/conversant/conversanttest/exemplary/simple-native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"secure": 1,
"bidfloor": 0.01,
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"ext": {
"bidder": {
"site_id": "108060",
Expand Down Expand Up @@ -97,4 +96,4 @@
]
}
]
}
}
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/exemplary/simple_app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"secure": 1,
"bidfloor": 0.01,
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"banner": {
"format": [{"w": 300, "h": 250}]
},
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/exemplary/simple_audio_app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
"secure": 1,
"bidfloor": 0.01,
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"audio": {
"mimes": [ "audio/vnd.wav", "audio/mpeg", "audio/mp4" ],
"protocols": [3,6,7,8]
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/exemplary/simple_audio_site.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"secure": 1,
"bidfloor": 0.01,
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"audio": {
"mimes": [ "audio/vnd.wav", "audio/mpeg", "audio/mp4" ],
"protocols": [3,6,7,8]
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/exemplary/video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"bidfloor": 25.0,
"bidfloorcur": "USD",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"video": {
"w": 300,
"h": 250,
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/supplemental/server_badresponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
{
"id": "1",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"banner": {
"format": [{"w": 300, "h": 250}]
},
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/supplemental/server_nocontent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
{
"id": "1",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"banner": {
"format": [{"w": 300, "h": 250}]
},
Expand Down
1 change: 0 additions & 1 deletion adapters/conversant/conversanttest/supplemental/server_unknownstatus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
{
"id": "1",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"banner": {
"format": [{"w": 300, "h": 250}]
},
Expand Down
4 changes: 0 additions & 4 deletions adapters/conversant/conversanttest/supplemental/test_params.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
"secure": 1,
"tagid": "mytag",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"video": {
"api": [1,2],
"maxduration": 60,
Expand All @@ -127,7 +126,6 @@
"secure": 1,
"tagid": "mytag",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"video": {
"api": [1,2],
"maxduration": 60,
Expand Down Expand Up @@ -155,7 +153,6 @@
"secure": 1,
"tagid": "mytag",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"video": {
"api": [1,2],
"maxduration": 60,
Expand Down Expand Up @@ -183,7 +180,6 @@
"secure": 1,
"tagid": "mytag",
"displaymanager": "prebid-s2s",
"displaymanagerver": "2.0.0",
"video": {
"api": [1,2],
"maxduration": 60,
Expand Down
Loading