Skip to content

relevantBidAdapter: add useSourceBidderCode option #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugolm84 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

relevantBidAdapter: add useSourceBidderCode option #4694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions adapters/relevantdigital/relevantdigital.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ func setTMax(prebidBidRequest *openrtb2.BidRequest, pbsBufferMs int) {

func createBidRequest(prebidBidRequest *openrtb2.BidRequest, params []*openrtb_ext.ExtRelevantDigital) ([]byte, error) {
bidRequestCopy := *prebidBidRequest
// Copy Imp slice so patchBidImpExt only mutates this outgoing request.
// MakeBids receives the same request and needs the original Imp[].Ext
// to read useSourceBidderCode from bidder params.
bidRequestCopy.Imp = make([]openrtb2.Imp, len(prebidBidRequest.Imp))
copy(bidRequestCopy.Imp, prebidBidRequest.Imp)

err := patchBidRequestExt(&bidRequestCopy, params[0].AccountId)
if err != nil {
Expand Down Expand Up @@ -292,6 +297,17 @@ func isSupportedMediaType(bidType openrtb_ext.BidType) error {
return fmt.Errorf("bid type not supported %s", bidType)
}

func useSourceBidderCode(request *openrtb2.BidRequest) bool {
if request == nil || len(request.Imp) == 0 {
return false
}
impExt, err := getImpressionExt(&request.Imp[0])
if err != nil {
return false
}
return impExt.UseSourceBidderCode
}

func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.RequestData, responseData *adapters.ResponseData) (*adapters.BidderResponse, []error) {
if adapters.IsResponseStatusCodeNoContent(responseData) {
return nil, nil
Expand All @@ -306,6 +322,8 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.R
return nil, []error{err}
}

passSourceSeat := useSourceBidderCode(request)

bidResponse := adapters.NewBidderResponseWithBidsCapacity(len(response.SeatBid))
bidResponse.Currency = response.Cur
var errs []error
Expand All @@ -324,6 +342,9 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, requestData *adapters.R
Bid: &seatBid.Bid[i],
BidType: bidType,
}
if passSourceSeat {
b.Seat = openrtb_ext.BidderName(seatBid.Seat)
}
bidResponse.Bids = append(bidResponse.Bids, b)
}
}
Expand Down
131 changes: 131 additions & 0 deletions adapters/relevantdigital/relevantdigitaltest/supplemental/useSourceBidderCode.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
{
"mockBidRequest": {
"id": "3621f78b-abdf-4562-8eca-1c5e893387d0",
"imp": [
{
"id": "div-1",
"banner": {
"format": [
{
"w": 300,
"h": 250
}
]
},
"ext": {
"bidder": {
"accountId": "620523ae7f4bbe1691bbb815",
"pbsHost": "fakeHost",
"placementId": "620525862d7518bfd4bbb81e_620523b5d1dbed6b0fbbb817",
"useSourceBidderCode": true
}
}
}
],
"site": {
"domain": "somedomain.com",
"page": "https://somedomain.com"
},
"device": {
"ua": "userAgent",
"ip": "193.168.244.1"
}
},
"httpCalls": [
{
"expectedRequest": {
"uri": "https://fakeHost.relevant-digital.com/openrtb2/auction",
"body": {
"id": "3621f78b-abdf-4562-8eca-1c5e893387d0",
"imp": [
{
"id": "div-1",
"banner": {
"format": [
{
"w": 300,
"h": 250
}
]
},
"ext": {
"prebid": {
"storedrequest": {
"id": "620525862d7518bfd4bbb81e_620523b5d1dbed6b0fbbb817"
}
}
}
}
],
"site": {
"domain": "somedomain.com",
"page": "https://somedomain.com"
},
"device": {
"ua": "userAgent",
"ip": "193.168.244.1"
},
"ext": {
"prebid": {
"debug": false,
"storedrequest": {
"id": "620523ae7f4bbe1691bbb815"
}
},
"relevant": {
"adapterType": "server",
"count": 1
}
},
"tmax": 750
},
"impIDs": ["div-1"]
},
"mockResponse": {
"status": 200,
"body": {
"id": "3621f78b-abdf-4562-8eca-1c5e893387d0",
"seatbid": [
{
"seat": "pubmatic",
"bid": [
{
"id": "8ee514f1-b2b8-4abb-89fd-084437d1e800",
"impid": "div-1",
"price": 0.5,
"adm": "some-test-ad",
"crid": "crid_10",
"w": 300,
"h": 250,
"mtype": 1
}
]
}
],
"cur": "USD"
}
}
}
],
"expectedBidResponses": [
{
"currency": "USD",
"bids": [
{
"bid": {
"id": "8ee514f1-b2b8-4abb-89fd-084437d1e800",
"impid": "div-1",
"price": 0.5,
"adm": "some-test-ad",
"crid": "crid_10",
"w": 300,
"h": 250,
"mtype": 1
},
"type": "banner",
"seat": "pubmatic"
}
]
}
]
}
129 changes: 129 additions & 0 deletions adapters/relevantdigital/relevantdigitaltest/supplemental/useSourceBidderCodeDisabled.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
{
"mockBidRequest": {
"id": "3621f78b-abdf-4562-8eca-1c5e893387d0",
"imp": [
{
"id": "div-1",
"banner": {
"format": [
{
"w": 300,
"h": 250
}
]
},
"ext": {
"bidder": {
"accountId": "620523ae7f4bbe1691bbb815",
"pbsHost": "fakeHost",
"placementId": "620525862d7518bfd4bbb81e_620523b5d1dbed6b0fbbb817"
}
}
}
],
"site": {
"domain": "somedomain.com",
"page": "https://somedomain.com"
},
"device": {
"ua": "userAgent",
"ip": "193.168.244.1"
}
},
"httpCalls": [
{
"expectedRequest": {
"uri": "https://fakeHost.relevant-digital.com/openrtb2/auction",
"body": {
"id": "3621f78b-abdf-4562-8eca-1c5e893387d0",
"imp": [
{
"id": "div-1",
"banner": {
"format": [
{
"w": 300,
"h": 250
}
]
},
"ext": {
"prebid": {
"storedrequest": {
"id": "620525862d7518bfd4bbb81e_620523b5d1dbed6b0fbbb817"
}
}
}
}
],
"site": {
"domain": "somedomain.com",
"page": "https://somedomain.com"
},
"device": {
"ua": "userAgent",
"ip": "193.168.244.1"
},
"ext": {
"prebid": {
"debug": false,
"storedrequest": {
"id": "620523ae7f4bbe1691bbb815"
}
},
"relevant": {
"adapterType": "server",
"count": 1
}
},
"tmax": 750
},
"impIDs": ["div-1"]
},
"mockResponse": {
"status": 200,
"body": {
"id": "3621f78b-abdf-4562-8eca-1c5e893387d0",
"seatbid": [
{
"seat": "pubmatic",
"bid": [
{
"id": "8ee514f1-b2b8-4abb-89fd-084437d1e800",
"impid": "div-1",
"price": 0.5,
"adm": "some-test-ad",
"crid": "crid_10",
"w": 300,
"h": 250,
"mtype": 1
}
]
}
],
"cur": "USD"
}
}
}
],
"expectedBidResponses": [
{
"currency": "USD",
"bids": [
{
"bid": {
"id": "8ee514f1-b2b8-4abb-89fd-084437d1e800",
"impid": "div-1",
"price": 0.5,
"adm": "some-test-ad",
"crid": "crid_10",
"w": 300,
"h": 250,
"mtype": 1
},
"type": "banner"
}
]
}
]
}
Loading
Loading