Bump napi-build-utils from 1 to 2#204
Merged
vweevers merged 2 commits intoprebuild:masterfrom Jan 22, 2025
Merged
Conversation
vweevers
requested changes
Jan 17, 2025
Member
|
For anyone wondering why
We can release this as a patch here. |
vweevers
approved these changes
Jan 17, 2025
Contributor
Author
|
Is there any estimate on when a release with this fix might be available? @vweevers |
Member
|
Released in 7.1.3. Thanks! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203.
I don't have a good mechanism to test the changes inside prebuild-install without publishing releases of these packages, but I can test the new version of napi-build-utils in our package and confirm that it detects the correct version of napi.
I tested this in the @mongodb-js/zstd package by installing napi-build-utils@2.0.0 and confirming that it now detects an napi version of 4:
before fix:
after fix:
let met know if there's anything else you'd like in this PR or any additional testing you can think of. Thanks!