Skip to content

Name some printer/diploma routines, name wd434, misc. cleanup#139

Merged
Rangi42 merged 3 commits intopret:masterfrom
Narishma-gb:update
Sep 10, 2025
Merged

Name some printer/diploma routines, name wd434, misc. cleanup#139
Rangi42 merged 3 commits intopret:masterfrom
Narishma-gb:update

Conversation

@Narishma-gb
Copy link
Contributor

Main changes in this PR are:

  • Add a new constant : PIKACHU_SPRITE_INDEX, currently in map_objects_constants.asm
  • Name wd434 as wPikachuCollisionCounter : writing a non-zero value makes Pikachu sprite impassable for the player when turning around. There is a countdown of 8 frames until its sprite becomes passable. This allows easy facing/interacting with Pikachu.
  • Fix for Are the labels in CheckPikachuFaintedOrStatused wrong? #103 : renamed sublabels and changed name to CheckPikachuStatusCondition
  • Simplify IsThisPartymonStarterPikachu_Party/_Box into IsThisPartyMonStarterPikachu / IsThisBoxMonStarterPikachu
  • Name some functions in engine/printer/printer.asm
  • Remove large tilemaps from asm files, using INCBIN instead
  • Diploma graphics and tilemaps are now stored in gfx/diploma, because they are unrelated to surfing minigame
  • Change IsStarterPikachuInOurParty into IsStarterPikachuAliveInOurParty, to reflect its behaviour, + comments
  • Name remaining symbols in engine/events/diploma2.asm
  • Fix a few constants here and there, change a few ldi [hl] > ld [hli]
  • Add Yellow-specific Bench guy bug comment

Copy link
Member

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing; please add NAME_LENGTH_JP to constants/text_constants.asm:

 DEF NAME_LENGTH EQU 11
 DEF ITEM_NAME_LENGTH EQU 13
 DEF NAME_BUFFER_LENGTH EQU 20
+DEF NAME_LENGTH_JP EQU 6

Copy link
Member

@Rangi42 Rangi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Rangi42 Rangi42 merged commit d237b01 into pret:master Sep 10, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Sep 10, 2025
* Name some printer/diploma routines

* Name `wd434`

* Name `NAME_LENGTH_JP`

* Rename `callabd`/`calladb` to `farcall`/`callfar`
@Narishma-gb Narishma-gb deleted the update branch September 10, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants