Rename NidorinoIntro to PikachuIntro to avoid confusion#142
Rename NidorinoIntro to PikachuIntro to avoid confusion#142CreamElDudJafar wants to merge 1 commit intopret:masterfrom
Conversation
|
FYI on another note: There a few unknown bg map palettes still but I am not certain what they are related to at this time. |
Rangi42
left a comment
Rangi42
left a comment
There was a problem hiding this comment.
Thanks, but I'm not sure about this PR. engine/movie/intro still exists with at least some of the Red/Blue intro code (InitIntroNidorinoOAM). Meanwhile there's also engine/movie/intro_yellow.asm. Neither of those engine files was affected by this PR, which is surprising assuming either of them references this blk/pal packet data somehow. I expect that more labels+constants+comments need auditing/editing for this to be a complete improvement.
| SetPal_NidorinoIntro: | ||
| ld hl, PalPacket_NidorinoIntro | ||
| ld de, BlkPacket_NidorinoIntro | ||
| ; used for splash screen and the Pikachu intro scenes surfing and flying |
There was a problem hiding this comment.
If the label name is fine, this comment isn't necessary.
| ; used for splash screen and the Pikachu intro scenes surfing and flying |
|
Sounds good Ill make the change and go through the movie intro files. But for fun I did remove intro nidorino and it did have weird color effects |
2 participants
Renamed NidorinoIntro Palette related stuff to PikachuIntro since Nidorino doesn't appear in intro scene or Oak intro now.
Added a comment to that the PikachuIntro attributes are used for the splash screen and certain intro animations such as when Pikachu is surfing and flying.