Skip to content

feat: fastswap intents #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
owen-eth merged 8 commits into from
Jan 27, 2026
Merged

feat: fastswap intents #44

owen-eth merged 8 commits into from
Jan 27, 2026

Conversation

@owen-eth
Copy link
Contributor

@owen-eth owen-eth commented Jan 16, 2026

No description provided.

@owen-eth owen-eth requested a review from passandscore January 16, 2026 19:15
@vercel
Copy link

vercel bot commented Jan 16, 2026

@owen-eth must be a member of the Primev team on Vercel to deploy.
- Click here to add @owen-eth to the team.
- If you initiated this build, request access.
- If you're already a member of the Primev team, make sure that your Vercel account is connected to your GitHub account.

Learn more about collaboration on Vercel and other options here.

@vercel
Copy link

vercel bot commented Jan 16, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fastprotocolapp Ready Ready Preview, Comment Jan 22, 2026 1:51am

Request Review

passandscore
passandscore reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

@passandscore passandscore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets further review the handling of ETH

contracts/src/FastSettlementV3.sol Outdated
uint256 startInputBal = _getBalance(intent.inputToken);

// Pull funds
IPermit2.PermitTransferFrom memory permit = IPermit2.PermitTransferFrom({
Copy link
Contributor

@passandscore passandscore Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the input token is address(0)? We cannot pass that to the permit function.

Copy link
Contributor Author

@owen-eth owen-eth Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah ETH handling got messed up, will address. We should not even be allowing ETH as input token - we will need to prompt user to execute a wrapping tx so that WETH can be used instead.

@owen-eth owen-eth merged commit 0b1e353 into main Jan 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@passandscore passandscore passandscore left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@owen-eth @passandscore