fix: add call path to revert errors and improve sender recovery #880
+226
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant777
force-pushed
the
fix/inline-sim-error-context-and-sender-recovery
branch
3 times, most recently
from
1240c27 to
6fd7812
Compare
- Include target address in revert error messages for both eth_simulateV1 and debug_traceCall to help identify which call failed - Handle contract creation case consistently (show "contract creation" when to address is empty) - Add recoverSender function that handles different tx types correctly: pre-EIP-155 (HomesteadSigner), EIP-155, EIP-2930, EIP-1559, EIP-4844 - Add tests with real mainnet transactions (pre-EIP-155 and EIP-1559) to verify full simulation pipeline end-to-end
kant777
force-pushed
the
fix/inline-sim-error-context-and-sender-recovery
branch
from
6fd7812 to
d698958
Compare
iowar
approved these changes
Jan 28, 2026
Contributor
iowar
left a comment
iowar
left a comment
There was a problem hiding this comment.
looks good.. I think it’s testable now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist before requesting a review