Open
Conversation
Collaborator
|
The When the loom project on disk was created using BayesDB's The assumptions in the code should be further loosened by:
|
fsaad
requested changes
Aug 13, 2018
Collaborator
fsaad
left a comment
There was a problem hiding this comment.
Please see #247 (comment) for requested change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is needed since the column names I am getting from loom while calling
_update_state(and
_retrieve_featureid_to_cgpm, specifically) don't follow the assumptions made in the code. In fact, the column names I am getting from loom are the actual natural language column names which seems correct (thus patching cgpm).I have a test case for this patch which depends on loom and bql -- I initially planned to include the
test case here (i.e the cgpm repo). Looking at the test suite however, I am not sure anymore if this makes sense (not much loom and BQL around in
cgpm/test); I am now planning to include this test in another repo focussed only on exporting models from loom. Open for suggestions here.Tested using the probcomp dev image as folllows:
Result: