fix(POS-1250): make 3ds iframe configurable from the outside #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Probably the best solution. Wonder if we shouldn't actually merge and deploy this one in favour of #165 ?
We touch the same number of forms in both PRs, after all.
Additionally, if we merge and deploy #165 first, it will fix the Bitstack issue, but if we are to merge this one, we would make a change for them again:
- #165 automatically resizes the iframe to "fullscreen" for screens narrower than 500 px.
- Bitstack is happy, because they don't need to do anything and they have a nicely displayed form.
- We merge this PR, removing the automagical iframe resize feature.
- Bitstack is unhappy, because the form is too small again and they must make changes in their processout.js config to adjust the height.
Collaborator
Author
|
I'm closing this one because I opened new PR after recent changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is second solution for the problem. In this case we're letting to configure iframe width & height from the outside of PO.js by passing additional argument to the payment functions. It requires more testing before release.
Solution
Notes
Jira Issue
https://checkout.atlassian.net/browse/POS-1250