fix(windows): add loading spinner when killing process #77
+46
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When clicking the X button and confirming "Yes" to kill a process, there was no visual feedback that the operation was in progress.
Solution
Wire up the existing
IsKillingproperty to the UI:Context
The
IsKillingproperty existed in:Models/PortInfo.cs(lines 77-88) - the property definitionViewModels/MainViewModel.cs(line 191) - setsIsKilling = truebefore killingChanges
platforms/windows/PortKiller/MainWindow.xamlNotes
InverseBoolToVisibilityConverterfrom the codebase