Fix accessibility issues for screen readers (Talkback) #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses all accessibility issues reported in #600 for Talkback screen reader compatibility: **1. Make button labels translatable and fix naming:** - Added translatable content descriptions for Search, More Options, and Drawer Menu buttons - Changed "Settings" button label to "More options" for better clarity - All button labels now use LocalFeedFlowStrings for proper internationalization - Files: HomeAppBar.kt **2. Add labels for text scaling buttons:** - Added content descriptions to the increase (+) and decrease (-) font size buttons - Screen readers will now properly vocalize "Increase font size" and "Decrease font size" - Files: FontSizeSliders.kt **3. Improve context menu accessibility:** - Updated all DropdownMenu components to use explicit PopupProperties - Set focusable=true to ensure proper focus management for screen readers - Set dismissOnBackPress=true to enable back gesture dismissal - Set dismissOnClickOutside=true for better UX - Files: FeedSourceContextMenu.kt, FeedItemContextMenu.kt, CategoryContextMenu.kt, HomeAppBarDropdownMenu.kt **4. Add accessibility for new ScrollToTopButton:** - Added content description for the newly added Scroll to Top FAB - Screen readers will now announce "Scroll to top" when focused - Files: ScrollToTopButton.kt **New translatable strings added to strings.xml:** - search_button_content_description: "Search" - more_options_button_content_description: "More options" - drawer_menu_button_content_description: "Open navigation menu" - increase_font_size_button_content_description: "Increase font size" - decrease_font_size_button_content_description: "Decrease font size" - scroll_to_top_button_content_description: "Scroll to top" Fixes #600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses all accessibility issues reported in #600 for Talkback screen reader compatibility:
1. Make button labels translatable and fix naming:
2. Add labels for text scaling buttons:
3. Improve context menu accessibility:
4. Add accessibility for new ScrollToTopButton:
New translatable strings added to strings.xml:
Fixes #600