Skip to content

Adding localization #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Future998 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding localization #445

Future998 wants to merge 3 commits into from

Conversation

@Future998
Copy link
Contributor

@Future998 Future998 commented Oct 25, 2024

  • Replaced the text for localization.
  • Added Select to select the language in the Header.
  • Localization of the DateTime format.
  • Added Russian language.

@rchincha
Copy link
Contributor

rchincha commented Oct 31, 2024

@Future998 thanks for the PR.

@rchincha
Copy link
Contributor

rchincha commented Oct 31, 2024

image

@rchincha
Copy link
Contributor

rchincha commented Oct 31, 2024

@Future998 seems to be working nicely.

Can you pls rebase and fix the merge conflicts?

andaaron
andaaron approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rchincha
Copy link
Contributor

rchincha commented Nov 1, 2024

@Future998 pls address the ci failures.

@Future998 Future998 force-pushed the localization branch 4 times, most recently from 3dd802a to 0eef473 Compare November 5, 2024 11:17
@Future998
Copy link
Contributor Author

Future998 commented Nov 8, 2024

@rchincha, OK, it's ready

@codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.84375% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.12%. Comparing base (c78b303) to head (94348ea).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Login/ThirdPartyLoginComponents.jsx 25.00% 3 Missing ⚠️
src/components/Header/Header.jsx 71.42% 2 Missing ⚠️
src/components/Shared/TagCard.jsx 83.33% 1 Missing ⚠️
src/components/User/ApiKeys/ApiKeyCard.jsx 0.00% 1 Missing ⚠️
...rc/components/User/ApiKeys/ApiKeyConfirmDialog.jsx 0.00% 1 Missing ⚠️
src/components/User/ApiKeys/ApiKeyDialog.jsx 0.00% 1 Missing ⚠️
src/components/User/ApiKeys/ApiKeyRevokeDialog.jsx 0.00% 1 Missing ⚠️
src/components/User/ApiKeys/ApiKeys.jsx 0.00% 1 Missing ⚠️
src/utilities/i18n.js 0.00% 1 Missing ⚠️
.../utilities/vulnerabilityAndSignatureComponents.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   85.00%   84.12%   -0.89%     
==========================================
  Files          63       64       +1     
  Lines        1961     2041      +80     
  Branches      532      543      +11     
==========================================
+ Hits         1667     1717      +50     
- Misses        284      311      +27     
- Partials       10       13       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future998
Copy link
Contributor Author

Future998 commented Nov 11, 2024

I don't quite understand what to do next?

@Future998 Future998 force-pushed the localization branch 2 times, most recently from 4f37f4e to 73b21a5 Compare November 14, 2024 17:01
@Future998
Copy link
Contributor Author

Future998 commented Nov 14, 2024

@rchincha, OK, it's ready

@rchincha
Copy link
Contributor

rchincha commented Nov 15, 2024

@Future998 This PR is a little late for the very next release. Will consider this for the next release after.
Also canvasing feedback from the community about ii8n in OCI registries in general.

raulkele
raulkele approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@raulkele raulkele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. The changes look good to me. If we want to add localisation, this will also set the basis for implementing other locales.

src/components/Header/Header.jsx

const { t, i18n } = useTranslation();
const [selectedLanguage, setSelectedLanguage] = useState(i18n.language);
const handleLanguageChange = (event) => {
Copy link
Collaborator

@raulkele raulkele Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test with language selection would be good to have, just to have it covered as it would be a new feature

@Future998
Copy link
Contributor Author

Future998 commented Dec 13, 2024

Like that?

@Future998
Adding localization
a661667 
- Replaced the text for localization.
- Added Select to select the language in the Header.
- Localization of the DateTime format.
- Added Russian language.

Signed-off-by: Alexander Burmatov <thatman@altlinux.org>
@Future998
Fix tests
7edc123 
The translation of the application affected the tests.

Signed-off-by: Alexander Burmatov <thatman@altlinux.org>
@Future998
Add test for language select
94348ea 
Signed-off-by: Alexander Burmatov <thatman@altlinux.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andaaron andaaron andaaron approved these changes

@raulkele raulkele raulkele approved these changes

@Andreea-Lupu Andreea-Lupu Awaiting requested review from Andreea-Lupu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Future998 @rchincha @andaaron @raulkele