use built-in FindOpenGL module for GLES with cmake 3.27+ #929
+29
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaetgen-wup
force-pushed
the
cmake-version-check-gles
branch
from
bae1912 to
2a79f95
Compare
2 tasks
mbaetgen-wup
force-pushed
the
cmake-version-check-gles
branch
from
2a79f95 to
f86ffa5
Compare
mbaetgen-wup
changed the title
Member
|
Probably needs to be done in the same way in the config package script here. I also always forget about this file, as seen in the 4.1.6 PR 😆 Guess you could also squash the changes into a single commit before merging, as it's only a few lines. |
kblaschke
requested changes
Nov 11, 2025
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Please also add the version check conditional around the same line in the CMake package config file.
The new combined function no longer returns the image size, so we need to load the image ourselves, store the size and then pass the buffer to SOIL_create_OGL_texture().
mbaetgen-wup
force-pushed
the
cmake-version-check-gles
branch
from
ecfb4c8 to
09941b5
Compare
kblaschke
requested changes
Nov 13, 2025
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Just two small details left.
Co-authored-by: Kai Blaschke <kai.blaschke@kb-dev.net>
…make-version-check-gles # Conflicts: # src/libprojectM/projectM4Config.cmake.in
Co-authored-by: Kai Blaschke <kai.blaschke@kb-dev.net>
…make-version-check-gles
mbaetgen-wup
changed the title
Member
|
If your changes are ready for review, just hit the "Re-request review" button, I'll then do a final check. Already looking good though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.