Add an AKS migration e2e run #11521
Add an AKS migration e2e run #11521
Conversation
marvin-tigera
added
release-note-required
lwr20
force-pushed
the
lwr-aks-migrate
branch
from
ac166f2 to
2757253
Compare
lwr20
added
docs-not-required
There was a problem hiding this comment.
Pull request overview
This PR adds an end-to-end test to exercise the AKS migration process from vendored Calico CNI to unmanaged Calico CNI, following the documentation at https://docs.tigera.io/calico/latest/getting-started/kubernetes/managed-public-cloud/aks-migrate.
Key Changes:
- Added conditional logic in the test script to trigger AKS migration via
bz addons run aks-migrate:setup - Created a new test job "AKS migrate from vendored Calico CNI to Calico CNI" with 7-hour execution limit
- Configured test environment with vendored CNI setup (
USE_VENDORED_CNI: true,CNI_PLUGIN: Calico) and migration trigger (DESIRED_POLICY: Calico)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.semaphore/end-to-end/scripts/body_standard.sh |
Added conditional block to execute AKS migration setup when DESIRED_POLICY is set |
.semaphore/end-to-end/pipelines/iptables.yml |
Added new AKS migration test job configuration under the AKS block with appropriate environment variables |
|
|
||
| # Perform the AKS migration following the instructions here: | ||
| # https://docs.tigera.io/calico/latest/getting-started/kubernetes/managed-public-cloud/aks-migrate | ||
| if [[ -n "$DESIRED_POLICY" ]]; then |
There was a problem hiding this comment.
The variable name DESIRED_POLICY is ambiguous for triggering AKS migration. The condition only checks if the variable is non-empty (-n), making it function as a boolean flag, but the name suggests it's a configuration value. Consider using a more explicit name like AKS_MIGRATE to match the pattern of OPERATOR_MIGRATE on line 46, or if the value matters, document why and ensure the bz addons run aks-migrate:setup command uses it.
| if [[ -n "$DESIRED_POLICY" ]]; then | |
| if [[ -n "$AKS_MIGRATE" ]]; then |
| - name: INSTALLER | ||
| value: operator |
There was a problem hiding this comment.
The INSTALLER environment variable is set to "operator" at the job level (line 171-172) but is also defined as "helmerator" at the task level (line 185-186). While the job-level value will take precedence, this duplication could cause confusion. Consider removing the job-level definition if the task-level default is incorrect, or document why both are needed.
| - name: INSTALLER | |
| value: operator |
3 participants
Description
Add an e2e test run to exercise the process in https://docs.tigera.io/calico/latest/getting-started/kubernetes/managed-public-cloud/aks-migrate
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.