[refactor] Remove bgp_conf_watcher dependency on pubsub#806
Open
aritrbas wants to merge 1 commit intonsk-split-svcfrom
Open
[refactor] Remove bgp_conf_watcher dependency on pubsub#806aritrbas wants to merge 1 commit intonsk-split-svcfrom
aritrbas wants to merge 1 commit intonsk-split-svcfrom
Conversation
Signed-off-by: Aritra Basu <aritrbas@cisco.com>
sknat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the dependency of
BGPConfigurationWatcheron the pubsub infra so that we can remove pubsub altogether.BGPConfigurationWatchernow uses a Calico API watch and directly notifies theFelixServeron changes.BGPConfChangedhave been eliminated.FelixServeris now notified via a simple callback when the BGP configuration changes, but actual handling of the update is not implemented yet (we log and trigger a restart to ensure the system reloads configuration).Made the changes on top of the nsk-split-svc branch for now, will rebase on top of master once those commits for single thread agent are merged.