add NonInteractive to nuget restore#95
Open
watashiSHUN wants to merge 5 commits intoprojectkudu:masterfrom
Open
add NonInteractive to nuget restore#95watashiSHUN wants to merge 5 commits intoprojectkudu:masterfrom
watashiSHUN wants to merge 5 commits intoprojectkudu:masterfrom
Conversation
davidebbo
approved these changes
Mar 19, 2018
davidebbo
approved these changes
May 11, 2018
davidebbo
reviewed
May 20, 2018
| if (projectType === ProjectType.wap || projectType === ProjectType.website || projectType === ProjectType.python) { | ||
| // For .NET the default script type is batch | ||
| scriptType = ScriptType.batch; | ||
| scriptType = ScriptType.posh; |
Member
There was a problem hiding this comment.
This doesn't sound related to the PR. Also, the comment above needs adjustment, as it says default is batch.
I'm a bit worried about switching to posh for everyone, as I'm not sure it's been well tested.
Contributor
Author
There was a problem hiding this comment.
this is a side effect, I am pushing this to my repo for testing purpose, it will get reverted, and once I smash everything, it will be a NOOP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since "nuget restore" were called in different template, it make sense to just use a variable and centralize it.
it should fix #46