Post Registration #161
Open
Post Registration #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| preferenceEditor.putString(Constants.LOGGED_IN_USER_ID_KEY, String.valueOf(result.getId())); | ||
| preferenceEditor.putString(Constants.LOGGED_IN_USER_PASS_KEY, seller.getmPassword()); | ||
|
|
||
| Gson gson = new GsonBuilder() |
Contributor
There was a problem hiding this comment.
i've moved this code under cacheLoggedInUesrData method to be reusable.
# Conflicts: # app/src/main/java/com/mtesitoo/Constants.java # app/src/main/res/values/styles.xml
Contributor
Author
|
Hi @ptyagicodecamp, I've implemented the changes we commented on Slack. Please have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed registration flow: user now goes directly to Home screen after successfully creating a new account.
Once Home screen is loaded, a dialog will be prompted asking user to complete his profile, letting him decide "ok", "not now" or "do not ask again".
This check is performed every time the screen is created, as a reminder for the user to complete his profile