Add strict YAML parsing to reject unknown fields#608
Open
AdeshGhadage wants to merge 1 commit intoprometheus:masterfrom
Open
Add strict YAML parsing to reject unknown fields#608AdeshGhadage wants to merge 1 commit intoprometheus:masterfrom
AdeshGhadage wants to merge 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: AdeshGhadage <adeshghadage9@gmail.com>
AdeshGhadage
force-pushed
the
feature/strict-yaml-parsing
branch
from
11e60c8 to
207d1a6
Compare
Contributor
|
I believe you could use |
Comment on lines
+87
to
+91
| validFields := []string{ | ||
| "match", "name", "labels", "honor_labels", "observer_type", "legacy_buckets", | ||
| "legacy_quantiles", "match_type", "help", "action", "match_metric_type", "ttl", | ||
| "summary_options", "histogram_options", "scale", | ||
| } |
Contributor
There was a problem hiding this comment.
This will cause some burden to update the structs. We can use yaml.UnmarshalStrict. Also, @matthiasr what do you think of dropping those deprecated fields? They have been here a while.
Contributor
There was a problem hiding this comment.
Yeah, good idea, we can do some cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces strict YAML parsing for configuration files #546 . I am new to Prometheus. Please correct me if I misunderstand the issue.