Skip to content

Remove deprecations for php8.4 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prolic merged 1 commit into from
Jan 21, 2025
Merged

Remove deprecations for php8.4 #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Event/ActionEventEmitter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ interface ActionEventEmitter
*
* @return ActionEvent that can be triggered by the ActionEventEmitter
*/
public function getNewActionEvent(string $name = null, $target = null, $params = null): ActionEvent;
public function getNewActionEvent(?string $name = null, $target = null, $params = null): ActionEvent;

public function dispatch(ActionEvent $event): void;

Expand Down
2 changes: 1 addition & 1 deletion src/Event/ProophActionEventEmitter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function __construct(array $availableEventNames = [])
*
* @return ActionEvent that can be triggered by the ActionEventEmitter
*/
public function getNewActionEvent(string $name = null, $target = null, $params = null): ActionEvent
public function getNewActionEvent(?string $name = null, $target = null, $params = null): ActionEvent
{
if ($name === null) {
$name = 'action_event';
Expand Down
Loading