Skip to content

Conversation

@oxr463
Copy link
Collaborator

@oxr463 oxr463 commented Apr 16, 2023

Debug sonar-scanner failure.

@oxr463 oxr463 self-assigned this Apr 16, 2023
@oxr463 oxr463 added this to the PRoot v5.4.0 milestone Apr 16, 2023
@oxr463 oxr463 modified the milestones: PRoot v5.4.0, PRoot v5.5.0 May 13, 2023
oxr463 and others added 16 commits May 13, 2023 08:56
Disable the check to see if the executable being executed
is the same ELF machine as the host system. This is to
support the case where ELF objects are run under a custom
QEMU emulator or LD_LIBRARY_PATH.

Bug: #343
Newer versions of glibc apparently enforce argv to contain at least one
argument, regardless of what what passed to execlp(). This behavioral
change resulted in test-0cf405b0 performing an endless loop.

This commit addresses this problem by setting an environment variable to
indicate, whether the execlp() call has already been performed.
Fix both tests in the same vein as [1].  Note that this behavior had been
changed by Linux's [2], not by glibc as suggested by [1].

[1] 10dd605
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dcd46d897adb70d63e025f175a00a89797d31a43
Prepare for CARE release v2.3.0
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants