Add GitHub App Client #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbj338033
reviewed
Nov 22, 2025
| } | ||
|
|
||
| return services.map { service -> | ||
| val appResource = service.targetId?.let { appResources[it] }?.let { AppResourceResponse.of(it) } |
Member
There was a problem hiding this comment.
ServiceResponse에서 AppResource, DatabaseResource등의 Response로 변환하는게 낫지 않나
| val sha: String, | ||
| val commit: CommitInfo, | ||
| ) { | ||
| data class CommitInfo( |
Member
There was a problem hiding this comment.
CommitInfo말고 Commit이라 해도 무방하지 않으려나 상관없긴한데
| fun clone( | ||
| repositoryUrl: String, | ||
| branch: String, | ||
| targetDir: File, |
Member
There was a problem hiding this comment.
targetDir 고정으로 못하나? properties라던가 /root 등등
| repositoryUrl: String, | ||
| branch: String, | ||
| targetDir: File, | ||
| token: String? = null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.